Closed
Bug 1121865
Opened 10 years ago
Closed 10 years ago
Tapping blank space should not exit Homescreen edit mode
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S4 (23jan)
People
(Reporter: hcheng, Assigned: cwiiis)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details |
(deleted),
video/3gpp
|
Details |
*Description:
Spec defines: "To exit edit mode the user can tap done or tap the home button", but currently I can exit edit mode by tapping blank space at an expanded group.
*2.2 UX Spec page 15:
https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2709316676/24961186345/1
*Env:
Build ID 20150114002502
Gaia Revision 7c5b27cad370db377b18a742d3f3fdb0070e899f
Gaia Date 2015-01-12 17:32:38
Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Gecko Version 37.0a2
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150114.040029
Firmware Date Wed Jan 14 04:00:40 EST 2015
Bootloader L1TC000118D0
Reporter | ||
Updated•10 years ago
|
blocking-b2g: --- → 2.2?
Flags: needinfo?(chrislord.net)
Whiteboard: [systemsfe]
Reporter | ||
Updated•10 years ago
|
Blocks: app-grouping
Assignee | ||
Comment 1•10 years ago
|
||
Not an app-grouping bug, but a pre-existing homescreen behaviour that we now want changed.
Assignee: nobody → chrislord.net
No longer blocks: app-grouping
Status: NEW → ASSIGNED
Flags: needinfo?(chrislord.net)
Summary: (App-grouping) tapping blank space at an expanded group should not exit Homescreen edit mode → Tapping blank space should not exit Homescreen edit mode
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8552458 -
Flags: review?(kgrandon)
Comment 4•10 years ago
|
||
Comment on attachment 8552458 [details]
Don't dismiss edit mode when tapping a blank space
lgtm.
Attachment #8552458 -
Flags: review?(kgrandon) → review+
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8552458 [details]
Don't dismiss edit mode when tapping a blank space
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Tapping a blank area in edit mode dismisses the edit screen, which is incongruous with other behaviour and unexpected.
[Testing completed]: On master for a couple of days
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: None
Attachment #8552458 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Attachment #8552458 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 7•10 years ago
|
||
Reporter | ||
Comment 8•10 years ago
|
||
verify v2.2
--env info--
Build ID 20150125002503
Gaia Revision 0518f4581a0925c0b703d730ef289ab15cbd1216
Gaia Date 2015-01-24 20:56:43
Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c6aa604a7967
Gecko Version 37.0a2
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150125.035924
Firmware Date Sun Jan 25 03:59:36 EST 2015
Bootloader L1TC000118D0
Status: RESOLVED → VERIFIED
Comment 10•9 years ago
|
||
This bug has been verified as pass on latest Nightly build of Flame master and Nexus5 master.
STR:
1. Long press a blank place on Homescreen.
2. After the homescreen edit mode is opened, then tap other blank place
Actual results: Device does not exit the Homescreen edit mode.
See attachment: verified_Flame_master.3GP
Reproduce rate: 0/8
Device: Flame master build(Pass)
Build ID 20150721160205
Gaia Revision 84c3bf622e211046d905803b34de5d331761f22d
Gaia Date 2015-07-21 16:28:35
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1875a5584e5f
Gecko Version 42.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150721.194129
Firmware Date Tue Jul 21 19:41:42 EDT 2015
Bootloader L1TC000118D0
Device: Nexus5 master(pass):
Build ID 20150721160205
Gaia Revision 84c3bf622e211046d905803b34de5d331761f22d
Gaia Date 2015-07-21 16:28:35
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1875a5584e5f
Gecko Version 42.0a1
Device Name hammerhead
Firmware(Release) 5.1
Firmware(Incremental) eng.cltbld.20150721.211608
Firmware Date Tue Jul 21 21:16:23 EDT 2015
Bootloader HHZ12f
QA Whiteboard: [MGSEI-Triage+]
You need to log in
before you can comment on or make changes to this bug.
Description
•