Closed Bug 1122015 Opened 10 years ago Closed 10 years ago

Refactor repository into sub packages

Categories

(Testing :: Firefox UI Tests, defect)

Version 2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Right now the repository has a single root folder called firefoxtests. That's not ideal given that even the harness and firefox-puppeteer will be located beneath it. Instead the harness and the ui libs have to be separated. This separation will also allow us later to easily move out those packages into their own repository. Proposed structure: - |- firefox_puppeteer |- firefox_ui_harness |- firefox_ui_tests I talked with Andrew on IRC and he generally agrees on that change. So I'm going ahead, and do it now.
Attached file github_pull_request.txt (deleted) —
Attachment #8549840 - Flags: review?(cmanchester)
Comment on attachment 8549840 [details] github_pull_request.txt As discussed on irc, let's make firefox_ui_test be firefox_ui_runner to avoid firefox_ui_test(s) confusion.
Attachment #8549840 - Flags: review?(cmanchester) → review+
We decided to keep the proposal from comment 0 and use firefox_ui_harness for lesser confusion. We do not only wrap the wrapper but also a couple of other classes which come with Marionette. So harness itself sounded best to us. PR #48 has been merged as https://github.com/mozilla/firefox-ui-tests/commit/f59ba41a538edf3d1bd675d47af796215eadce13
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: