Closed
Bug 1122356
Opened 10 years ago
Closed 10 years ago
Remove use of expression closures from WindowsPreviewPerTab.jsm
Categories
(Firefox :: Shell Integration, defect)
Firefox
Shell Integration
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: dao, Assigned: abdelrahman, Mentored)
References
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
|
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1121471 +++
Expression closures (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Expression_closures) are a nonstandard language extension we'd like to remove from SpiderMonkey.
In WindowsPreviewPerTab.jsm, I believe this only affects the resetCanvasPreview method:
https://hg.mozilla.org/mozilla-central/file/38fb85296699/browser/modules/WindowsPreviewPerTab.jsm#l203
The general pattern is that 'function (x) y' should be replaced with 'function (x) { return y; }'. However, resetCanvasPreview doesn't actually want to return something, so the 'return' statement should be omitted.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8550894 -
Flags: review?(dao)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8550894 [details] [diff] [review]
rev 1 - Remove use of expression closures
Thanks!
Attachment #8550894 -
Flags: review?(dao) → review+
|
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → a.ahmed1026
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [good first bug][lang=js] → [good first bug][lang=js][fixed-in-fx-team]
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=js][fixed-in-fx-team] → [good first bug][lang=js]
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•