Closed
Bug 1122677
Opened 10 years ago
Closed 10 years ago
Disallow request body when method is HEAD/GET
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bkelly
:
review+
baku
:
review+
|
Details | Diff | Splinter Review |
This was previously unspecified, but clarified by :annevk. Spec bug https://www.w3.org/Bugs/Public/show_bug.cgi?id=27846
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nsm.nikhil
|
|
Assignee | |
Comment 1•10 years ago
|
||
Spec bug has been fixed.
Attachment #8551993 -
Flags: review?(bkelly)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8551993 [details] [diff] [review]
Disallow request body when method is HEAD/GET
Review of attachment 8551993 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Flag baku for peer sign off.
::: dom/fetch/Request.cpp
@@ +220,5 @@
> if (aInit.mBody.WasPassed()) {
> + // HEAD and GET are not allowed to have a body.
> + nsAutoCString method;
> + request->GetMethod(method);
> + if (method.EqualsLiteral("HEAD") || method.EqualsLiteral("GET")) {
nit: Add a comment that HEAD and GET are guaranteed to be uppercase due to step 14.2 above.
Attachment #8551993 -
Flags: review?(bkelly)
Attachment #8551993 -
Flags: review?(amarchesini)
Attachment #8551993 -
Flags: review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
||
Updated•10 years ago
|
Attachment #8551993 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Gah, sorry I broke protocol there by landing before Andrea's review. Hadn't noticed that flag.
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•