Closed
Bug 1122701
Opened 10 years ago
Closed 10 years ago
Talos --develop sets remote to false
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Trying to run Talos locally on an Android device today, jmaher noticed that the --developer option forces remote=False:
http://hg.mozilla.org/build/talos/annotate/d6bcfd393641/talos/run_tests.py#l147
causing a failure when trying to run on a device with --develop. Workaround is to not use --develop and specify --webServer, but it would be nice to use --develop for Android too.
Assignee | ||
Comment 1•10 years ago
|
||
This allows me to run with --develop and a remote configuration, but I'm not sure if this will cause trouble for non-remote configurations.
Comment 2•10 years ago
|
||
Comment on attachment 8550482 [details] [diff] [review]
do not override remote configuration
Review of attachment 8550482 [details] [diff] [review]:
-----------------------------------------------------------------
::: talos/run_tests.py
@@ -143,5 @@
> # pass --no-remote to firefox launch, if --develop is specified to PerfConfigurator.py
> # set 'remote' in browser_config to False, if --develop is specified to PerfConfigurator.py
> if browser_config['develop']:
> browser_config['extra_args'] = '--no-remote'
> - browser_config['remote'] = False
please remove the comment about setting remote=False 4 lines up. I would rather make this work than fail on a random corner case of remote and --develop.
Attachment #8550482 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gbrown
Assignee | ||
Comment 3•10 years ago
|
||
With comment removed:
https://hg.mozilla.org/build/talos/rev/b50a30b490d4
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•