Closed
Bug 1123184
Opened 10 years ago
Closed 10 years ago
[Stingray] Enable l10n args format in browser context menu
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: chens)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file, 1 obsolete file)
This is a follow up of bug 1121816. We should follow https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs in BrowserContextMenu in smart system app.
Detail instruction is at https://bugzilla.mozilla.org/show_bug.cgi?id=1121816#c6
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → shchen
|
|
Assignee | |
Comment 1•10 years ago
|
||
Hi Zibi, this patch follows bug 1121816 to enable l10n args format, could you help to review the patch? thanks!
John, this may also affect system browser, please provide some feedback on this, thanks!
Attachment #8551691 -
Flags: review?(gandalf)
Attachment #8551691 -
Flags: feedback?(im)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8551691 [details]
Pull request to master
Looks great!
Attachment #8551691 -
Flags: review?(gandalf) → review+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8551691 [details]
Pull request to master
Looks good but please find my comments at PR.
Attachment #8551691 -
Flags: feedback?(im) → feedback+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8551691 [details]
Pull request to master
John, I've moved localizeElement to sharedutils, would you like to take another look? thanks!
Attachment #8551691 -
Flags: feedback+ → feedback?(im)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8551691 [details]
Pull request to master
looks good to me.
Attachment #8551691 -
Flags: feedback?(im) → feedback+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 7•10 years ago
|
||
Backout this patch because it breaks context menu functionality: we are no longer to fire up context menu in app-deck
https://github.com/mozilla-b2g/gaia/commit/f8bb3a5989a03a6df09444a783f7e8fbc219b547
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 8•10 years ago
|
||
Hi John,
This patch fixes the break in browser context menu, which previous patch made a mistake and took wrong element to localize[1]. Would you review this patch and give some feedback? thanks!
[1]: https://github.com/mozilla-b2g/gaia/pull/27523/files#diff-1d11f18a029c55e8845f8b2f6520f607R178
Attachment #8551691 -
Attachment is obsolete: true
Attachment #8553002 -
Flags: review?(im)
|
|
||
Comment 9•10 years ago
|
||
Comment on attachment 8553002 [details]
Pull request to master
looks good to me.
Attachment #8553002 -
Flags: review?(im) → review+
|
|
Assignee | |
Comment 10•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•