Closed Bug 1123852 Opened 10 years ago Closed 9 years ago

Update talos.json for bug 1121571

Categories

(Testing :: Talos, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: mstange, Assigned: jmaher)

References

Details

Attachments

(2 files, 3 obsolete files)

Attached patch patch (obsolete) (deleted) — Splinter Review
      No description provided.
Attachment #8551959 - Flags: review?(jmaher)
Comment on attachment 8551959 [details] [diff] [review]
patch

Review of attachment 8551959 [details] [diff] [review]:
-----------------------------------------------------------------

this is great.  2 things:
1) this also includes a change to make everything in pageloader use the messagemanager- so I expect numbers to change- ideally I would like to uplift this to aurora after we see the effects all this has
2) on the next update to talos.json, I planned on fixing the *snow* jobs to all have a --e10s, do you mind adding that to talos.json?  It has it for the chromez job, just not the other 3 jobs.  If not, not big deal.
Attachment #8551959 - Flags: review?(jmaher) → review+
Attached patch patch (obsolete) (deleted) — Splinter Review
like this?
Attachment #8551959 - Attachment is obsolete: true
Attachment #8551971 - Flags: review?(jmaher)
Comment on attachment 8551971 [details] [diff] [review]
patch

Review of attachment 8551971 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8551971 - Flags: review?(jmaher) → review+
Backed out for xperf permafail. Did we actually run this through Try before pushing?
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1deb10f8eb

https://treeherder.mozilla.org/logviewer.html#?job_id=5673332&repo=mozilla-inbound
Flags: needinfo?(mstange)
Oh. Yes, we did, but not without profiling, and I had attributed those errors to profiling. Sorry.

Joel, it looks like we need to adjust the main thread IO whitelist for tscroll.js and Profiler.js because loadFrameScript does main thread IO (!?).
Flags: needinfo?(mstange)
So, there's both xperf_whitelist.json and mtio-whitelist.json. Which one of those needs changing?
Flags: needinfo?(jmaher)
this just needs mtio-whitelist.json changes, should be easy to add, push to try and verify.  Lets keep track in this bug, I can get 15 minutes a bit later tonight to do it if others don't beat me to it.
Flags: needinfo?(jmaher)
Attachment #8552337 - Flags: review?(mstange) → review+
Attachment #8551971 - Attachment is obsolete: true
Attachment #8552483 - Flags: review?(mstange)
Attachment #8552483 - Flags: review?(mstange) → review+
Thanks Joel!
https://hg.mozilla.org/mozilla-central/rev/dcce08cf9c7d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1124740
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
the root cause for this is http://hg.mozilla.org/build/talos/rev/d6bcfd393641.  bummer, but we can remove this and land again.  There is on other patch which fixes a font issue for xperf file access which needs to land and get deployed.
updated talos.json after backing out bustage patch for pgo.  Try server runs:
non-pgo: https://treeherder.mozilla.org/#/jobs?repo=try&revision=16fe6f022b9d
pgo: https://treeherder.mozilla.org/#/jobs?repo=try&revision=190fa2dcb1b2
Assignee: mstange → jmaher
Attachment #8552483 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #8554153 - Flags: review?(ryanvm)
Blocks: 1123654
Comment on attachment 8554153 [details] [diff] [review]
talos.json modifications with only updated

rs=me
Attachment #8554153 - Flags: review?(ryanvm) → review+
https://hg.mozilla.org/mozilla-central/rev/babd56077826
Status: ASSIGNED → RESOLVED
Closed: 10 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: