Closed Bug 1123880 Opened 10 years ago Closed 4 years ago

Update snippets country code logic to use pref from search service

Categories

(Firefox for Android Graveyard :: General, defect)

35 Branch
All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: Margaret, Unassigned)

References

Details

Once Fennec uses the search service geo ip logic, we should just read from that pref for snippets, rather than doing a separate country code check.
Is this ticket: "Implement nsSearchService in Java"?
Flags: needinfo?(margaret.leibovic)
(In reply to Nick Alexander :nalexander from comment #1) > Is this ticket: "Implement nsSearchService in Java"? Nope, this but is to replace the snippets country code fetching logic [1] with a pref read (reading the pref set by the search service). [1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/Snippets.js#104
Flags: needinfo?(margaret.leibovic)
Just keep in mind that there might be a race between the two JS components.
(In reply to Nick Alexander :nalexander from comment #1) > Is this ticket: "Implement nsSearchService in Java"? Technically, this work has already started: http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/
Gavin noted that if we remove the country code fetch in the snippets code, we should talk to Geoff about updating our privacy policy, since it currently mentions something about this country code fetch for snippets.
Yes please do. Margaret would you mind setting up a brief meeting to talk about our plan and the impact it will have for the notice. I don't think we need too much time. Also, please add Marshall to the discussion.
I haven't heard back on this, is the plan to remove country code fetching still a go?
Not currently scheduled (no one is assigned to this work). (And to be clear, were this work to be completed, it would be "consolidating country code fetching to a single mechanism", not exactly "remove country code fetching".)
Blocks: 1281527
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.