Closed
Bug 1124114
Opened 10 years ago
Closed 10 years ago
TrustedWindow does not notify about the dialog being closed by the user
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
We used to notify to the chrome side about the user closing the trusted UI [1]. Not doing this means that the identity or payment flows won't be fulfilled if the user closes the trusted UI manually.
[1] https://github.com/mozilla-b2g/gaia/blob/v2.2/apps/system/js/trusted_ui.js#L216
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Updated•10 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → All
|
|
Assignee | |
Updated•10 years ago
|
Summary: TrustedWindowManager does not notify about the dialog being closed by the user → TrustedWindow does not notify about the dialog being closed by the user
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8555971 -
Flags: review?(alive)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8555971 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27753/files
Out of curious, why not listen to window-destroyed in gecko? Gecko has the iframe reference and it should know the window is removed.
Attachment #8555971 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks Alive!
That's a good point. I think it would be harder to keep track of payment windows from gecko this way, but I believe it's doable and probably cleaner. I might revisit this idea for bug 1126812.
https://github.com/mozilla-b2g/gaia/commit/321db3aed93a21f719fa918356f4200b8f465ac7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•