Closed Bug 1124456 Opened 10 years ago Closed 10 years ago

[e10s] XHR detected as normal network request in netmonitor and console

Categories

(DevTools :: General, defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

(e10s+, firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
e10s + ---
firefox39 --- fixed

People

(Reporter: jsantell, Assigned: tromey)

References

Details

Attachments

(1 file, 1 obsolete file)

View the XHR's on this page: http://bugmotodo.org/ The Bugzilla XHR's are classified as "other" when filtering; not json.
e10s only
Blocks: dte10s
Note that I am seeing an exception in NetworkMonitor._onRequestHeader; "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]" when calling: callbacks.getInterface(Ci.nsIXMLHttpRequest) I.e. the way determining whether nsIHttpChannel is XHR is broken. Honza
tracking-e10s: --- → ?
Also an issue in the console with the XHR filter.
Component: Developer Tools: Netmonitor → Developer Tools
Summary: XHR is be listed as "other" in netmonitor → XHR detected as normal network request in netmonitor and console
Summary: XHR detected as normal network request in netmonitor and console → [e10s] XHR detected as normal network request in netmonitor and console
I don't see the exception that Honza sees, but when I try this, "callbacks" is always null at that spot: // Determine if this is an XHR request. try { let callbacks = aChannel.notificationCallbacks; let xhrRequest = callbacks ? callbacks.getInterface(Ci.nsIXMLHttpRequest) : null; httpActivity.isXHR = event.isXHR = !!xhrRequest; ... leading the code to conclude that it isn't an XHR. Still digging to see why exactly this happens.
I think the problem is just that nsXMLRequest is instantiated in the content process, but this code from network-monitor.js is running the parent process.
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Attachment #8580789 - Flags: review?(vporof)
Comment on attachment 8580789 [details] [diff] [review] check channel's contentPolicyType to see if it is XMLHttpRequest Review of attachment 8580789 [details] [diff] [review]: ----------------------------------------------------------------- Cleaner code yay!
Attachment #8580789 - Flags: review?(vporof) → review+
Rebased; carrying over r+.
Attachment #8584474 - Flags: review+
Keywords: checkin-needed
Attachment #8580789 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: