Closed Bug 1124624 Opened 10 years ago Closed 9 years ago

Add transition to the group view panel

Categories

(Firefox OS Graveyard :: Gaia::SMS, enhancement)

ARM
Gonk (Firefox OS)
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1162030

People

(Reporter: ythej, Assigned: ythej, Mentored)

Details

Attachments

(2 files)

Steps to reproduce:
1. Open sms app.
2. open any message thread which has more than one recipients.
3. tap on the header text.

Expected result:
Transition should be there while we move to group view panel

Actual result:
There is no transition taken while we move to group view panel
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Severity: normal → enhancement
Mentor: schung
Hi Jenny,
Could you give your opinion on this bug?
Thank you.
Flags: needinfo?(jelee)
Hi Vishnu,

I agree we should have a slide in from right transition here. Please refer to the transition: inbox --> (tap on a thread) --> thread view. Thanks!
Flags: needinfo?(jelee)
Assignee: nobody → yvtheja
As Julien suggested we may implement off canvas technique to slide between the panels.For that we may have

*Thread-list panel -> left
*Thread-ui panel -> middle
*group-view -> right

So, we may add classes to main-wrapper to display each panel in the wrapper(indirectly we are moving the whole wrapper left/right).This can be done assigning negative values for margin.

Thanks Julien for proposing with this idea ! :)
You can try margin, "position: absolute", or even possibly a "display: flex" solution.
Attached file pull request for the bug fix 1124624 (deleted) —
Hi Julien,

When I open the sms app I am able to see the thread_list_ui but when I tried to move to thread_ui, i am seeing a blank page.But inspector shows that we are in  thread-messages.

Thank you.
Flags: needinfo?(felash)
Answered on github :)
Flags: needinfo?(felash)
This has been fixed by bug 1162030 :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: