Closed Bug 1124694 Opened 10 years ago Closed 10 years ago

[Ui Tour]Searchpanel bad positioning while moving the FF window.

Categories

(Firefox :: Tours, defect)

Product:
Firefox
Component:
Tours
Version:
35 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: VarCat, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

printsc.jpg
(deleted), image/jpeg
Details
MovingSearchPanelBug.patch
(deleted), patch
mossop
: review-
Details | Diff | Splinter Review
Attached image printsc.jpg (deleted) —
Environment: FF 35 Build Id: 20150108202552 OS: Win 7 x64, Mac Os X 10.9.5 STR: 1. Start FF with a new profile. 2. Add an entry in the searchbar. 3. Move the FF window Issue: Moving the FF window while the searchbarpanel is opened for the first time and the Ui Tour is present will create a miss-positioning of the panel. This bug is reproducible on FF 34 so it doesn't seem to be a regression.
Can you point me to the relevant code?
Attached patch resolved by calling the good functions (obsolete) (deleted) — — Splinter Review
Attached patch MovingSearchPanelBug.patch (deleted) — — Splinter Review
the same with some typo correction
Attachment #8554367 - Attachment is obsolete: true
Attachment #8554896 - Flags: review?(mconley)
Comment on attachment 8554896 [details] [diff] [review] MovingSearchPanelBug.patch 302 to florian who worked on the search stuff.
Attachment #8554896 - Flags: review?(mconley) → review?(florian)
Comment on attachment 8554896 [details] [diff] [review] MovingSearchPanelBug.patch Unfortunately, I don't fully understand what this code is trying to do. Moving the request to Dave who wrote this code. Sorry for the delay.
Attachment #8554896 - Flags: review?(florian) → review?(dtownsend)
Blocks: 1101654
Comment on attachment 8554896 [details] [diff] [review] MovingSearchPanelBug.patch This looks like it will break keeping the main panel open when interacting with the tour panels. Besides the plan is to remove this feature in bug 1123620
Attachment #8554896 - Flags: review?(dtownsend) → review-
Depends on: 1123620
No longer relevant due to bug 1123620.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: