Vaibhav (:vaibhav1994) Reporter
	Description • 10 years ago

There is a regression on linux32/linux64 and win platforms: http://alertmanager.allizom.org:8080/alerts.html?rev=ed9225015e22&showAll=1&testIndex=0&platIndex=0

for revision ed9225015e22

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 1 • 10 years ago

you can see that we have regressions in CART/TART on a mix of windows/linux in the above link.

It appears this is a fix for a security issue, so we might have to accept this as a regression.

As this isn't a surprise, it is sort of expected, I would like to know:
* is there any optimizations we can make to this to reduce the impact?
* if there isn't, I would like to get something kind of conclusion that we understand this and won't fix it right away so we can, understand when we will ship with this and what versions.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 2 • 10 years ago

this appears to have landed on beta/aurora- since this landed on beta, I want lsblakk to weigh in here on any concerns.

	David Baron :dbaron:
	Comment 3 • 10 years ago

This patch disabled a major piece of recent performance work, so performance regressions are expected.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 4 • 10 years ago

Thanks dbaron!  I suspect this will be a wontfix bug due to the nature of it- if there is tracking work to re-enable this work, that would be good to somehow associate with this bug!

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 5 • 10 years ago

Thanks Joel - I'm tracking bug 1125391 and the bug it relies on so that we hopefully avoid shipping this perf hit in 36.

	Cameron McCormack (:heycam)
	Comment 6 • 10 years ago

The fix and re-enabling of the optimisation landed on inbound and Aurora, but had to be backed out of Aurora.  I'll continue looking into that early next week.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 7 • 10 years ago

keep in mind next week Aurora will uplift to Beta.  That shouldn't change anything, but worth keeping in mind.

	Cameron McCormack (:heycam)
	Comment 8 • 9 years ago

With bug 1125391 landed, can we close this one?

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 9 • 9 years ago

yes, these graphs look fine on trunk as of Feb 22nd as well as aurora!