Closed
Bug 1125525
Opened 10 years ago
Closed 10 years ago
Overflow of contact name while tapping on the recepient in composer
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:2.2+, tracking-b2g:backlog, b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S5 (6feb)
People
(Reporter: rishav_, Assigned: ashutosh.nath.agarwal, Mentored)
References
Details
(Keywords: regression)
Attachments
(3 files)
STR:
1.Go to compose.
2.Add recepient (whose name is long i.e length>40)
3.Now tap on the recepient.
4.check in Confirm window: recepient name over flow.
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → ashutosh.nath.agarwal
Reporter | ||
Updated•10 years ago
|
Attachment #8554185 -
Flags: review?(azasypkin)
Comment 3•10 years ago
|
||
I think it's better do put this change in the Building Blocks.
Blocks: 1105857
Comment 4•10 years ago
|
||
Bug 1105857 is in v2.2 and v2.0m, I think we should fix in both branches.
blocking-b2g: --- → 2.2?
Assignee | ||
Comment 5•10 years ago
|
||
Hi. I'm a new contributor. I will fix it in the shared css (building blocks).
What should I do to fix in both batches - v2.2 and v2.0
Flags: needinfo?(felash)
Assignee | ||
Comment 6•10 years ago
|
||
Hi. I have fixed the bug in building blocks. Kindly guide me for the other branch. Thanks
Comment 7•10 years ago
|
||
(In reply to ashutosh.nath.agarwal from comment #6)
> Hi. I have fixed the bug in building blocks. Kindly guide me for the other
> branch. Thanks
I think it will be made automatically from your patch to master.
Flags: needinfo?(felash)
Comment 8•10 years ago
|
||
Comment on attachment 8554185 [details]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master
Per GitHub looks like Julien is already reviewing/reviewed this patch, redirecting to him :)
Ashutosh, please don't forget to ask for review from Pavel Ivanov (:ivanovpavel) as well as it's BB change that will affect a big chunk of applications.
Attachment #8554185 -
Flags: review?(azasypkin) → review?(felash)
Comment 9•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #4)
> Bug 1105857 is in v2.2 and v2.0m, I think we should fix in both branches.
As far as I remember v2.2 and v2.0m patches have a bunch of differences especially related to styling. So having said that I can't repro this issue on v2.0m - name is automatically broken into several lines there.
Reporter | ||
Updated•10 years ago
|
Attachment #8554185 -
Flags: review?(pivanov)
Comment 10•10 years ago
|
||
Comment on attachment 8554185 [details]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master
LGTM r+ and thanks :)
Attachment #8554185 -
Flags: review?(pivanov) → review+
Comment 11•10 years ago
|
||
triage: non-blocking but nice to have it fixed. please ask for approval to uplift.
blocking-b2g: 2.2? → backlog
Comment 12•10 years ago
|
||
Comment on attachment 8554185 [details]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master
r=me
Attachment #8554185 -
Flags: review?(felash) → review+
Comment 13•10 years ago
|
||
I restarted the failing tests just to be sure they're intermittent. Please don't add checkin-needed until they finish.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 14•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/27652
The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Comment 15•10 years ago
|
||
master: 229efc18377cd203be97d92995175c08e06307ad
Updated•10 years ago
|
Keywords: checkin-needed
Comment 16•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/27652
The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Assignee | ||
Comment 17•10 years ago
|
||
Thank you :)
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
Updated•10 years ago
|
Mentor: felash
Updated•10 years ago
|
Keywords: regression
Comment 19•10 years ago
|
||
Comment on attachment 8554185 [details]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Don't know
[User impact] if declined: See attachment 8587820 [details]
[Testing completed]: yes, it's in master since January.
[Risk to taking this patch] (and alternatives if risky): very low, one-line CSS change that does not change layout.
[String changes made]: none
Attachment #8554185 -
Flags: approval-gaia-v2.2?
Comment 21•10 years ago
|
||
Dear triagers, look at comment 11 :)
(does it mean we have a broken process?)
Comment 22•10 years ago
|
||
No, sorry for not making it clear.
We re-triaged this because this is a duplicate to bug 150793 being nominated.
The decision made today is based on below reasons:
1. it's a regression which has impact on the usability.
2. there's already a fix
3. risk is very low
4. we need blocking status to uplift
Comment 23•10 years ago
|
||
Please nominate this patch for Gaia v2.2 approval when you get a chance.
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → fixed
Flags: needinfo?(ashutosh.nath.agarwal)
Target Milestone: --- → 2.2 S5 (6feb)
Updated•10 years ago
|
Attachment #8554185 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 25•10 years ago
|
||
Comment 26•9 years ago
|
||
This issue is verified fixed on the latest 3.0 and 2.2 Nightly Flame builds.
Actual Results: Overly long contact names are wrapped and do not go off screen
Environmental Variables:
Device: Flame 3.0 KK (319 MB) (Full Flash)
BuildID: 20150604010200
Gaia: 9e10483c5808f94f4a0a9f6afe30aae2c5b42b4c
Gecko: 98820360ab66
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0
Environmental Variables:
Device: Flame 2.2 KK (319 MB) (Full Flash)
BuildID: 20150604002503
Gaia: b96e657ce2822df5da5da1a8ba91c38ad3281bc9
Gecko: 273f8ee45c88
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•