Closed
Bug 1126207
Opened 10 years ago
Closed 10 years ago
[RTL]Inconsistency between Dialer button positions and Lockscreen buttons positions when receiving a call
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)
Tracking
(feature-b2g:2.2+, b2g-v2.2 affected)
People
(Reporter: huayu.li, Unassigned)
References
Details
Attachments
(2 files)
[1.Description]:
[RTL][Dialer]When a incoming call appears on lockscreen, the location of two icon ["Answer "&"Decline" ] are not mirrored, but these two icon are mirrored when it's not in lockscreen.
see attachment:dail.png
[2.Testing Steps]:
Prerequisite: Set system language as Arabic and insert SIM card.
1.Press power key to lock screen.
2.A call comes.
3.Check the page of Incoming call.
[3.Expected Result]:
3.The icon of "Answer"&"decline" should be mirrored in RTL.
[4.Actual Result]:
3.The icon of "Answer"&"decline" are not mirrored in RTL.
[5.Reproduction build]:
Flame 2.2 build:
Gaia-Rev 0518f4581a0925c0b703d730ef289ab15cbd1216
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c6aa604a7967
Build-ID 20150126002536
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20150126.042138
FW-Date Mon Jan 26 04:21:49 EST 2015
Bootloader L1TC000118D0
[6.Reproduction Frequency]:
Always Recurrence,5/5
[7.TCID]:
Free Test
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
status-b2g-v2.2:
--- → affected
Can we put this consistency issue as under the feature-b2g flag?
Flags: needinfo?(doliver)
See comment 2.
Flags: needinfo?(doliver) → needinfo?(whuang)
Comment 4•10 years ago
|
||
triage: P1, need to align these two screens. NI to stephany to clarify the proper placement of the two buttons.
feature-b2g: --- → 2.2+
Flags: needinfo?(swilkes)
Priority: -- → P1
Comment 5•10 years ago
|
||
As noted on page 6 of the pattern in both the 2.2 and later versions, these do not change.
This bug is not correct: the expected behavior stated in the original description does not reflect the expected behavior as described in the bidi pattern. What is going on here with test plans? Flagging Delphine and Joe on this point, as this is not the first bug I've seen like this.
This was reviewed and accepted with many members of the Arabic community during the Portland work week.
Flags: needinfo?(swilkes)
Flags: needinfo?(jcheng)
Flags: needinfo?(delphine)
Comment 6•10 years ago
|
||
Stephany: this bug was filed yesterday and we only fell upon it during triage this morning. It seems there are some cases where there is still confusion about the pattern, please bear with us ;) Testers have the UX patterns and should be referring to them.
Here I believe the confusion is that in this particular case in RTL, the lockscreen button pattern "differs" when you receive a call from the expected "Answer" and "Decline" button pattern. In fact, the lockscreen is dispayed correctly at the moment in RTL since Lockscreen images should not mirror (p.6 UX specs). And the Answer and Decline buttons when receiving a call are placed correctly as well, since as per UX rule of thumbs "Location of Negative & Positive Action Buttons should be swapped ".
I understand the confusion here, since the pattern doesn't seem consistent with this particular case. That said, the title of bug does not reflect reality. I'll rename to reflect the issue here. Please follow-up if needed. Asking Ahmed for his insight on this as well.
@Josh: please make sure that Marigold testers have correctly reflected this in their recent test cases. Going through the cases now but let's get a many eyes on this as possible. THanks!
Flags: needinfo?(delphine)
Summary: [RTL][Dialer]The position of "Answer"&"Decline" are not mirrored while device receives call in lockscreen. → [RTL]Inconsistency between Dialer button positions and Lockscreen buttons positions when receiving a call
Updated•10 years ago
|
Flags: needinfo?(nefzaoui)
Comment 7•10 years ago
|
||
Hey Delphine,
Thanks for bringing in the quote from the spec! I guess that solves it then
> Location of Negative & Positive Action Buttons should be swapped
I guess I have the same understanding here, they should indeed be swapped :)
Flags: needinfo?(nefzaoui)
Comment 8•10 years ago
|
||
NO.
Please follow the pattern, which explicitly says they DO NOT change on Lockscreen. We talked about it extensively and noted it in the pattern for a reason.
If we need a pattern review, let's do that. Bugs in which I say "follow the pattern" are taking up a LOT of time these days, and Bugzilla is not the place to discuss or change the pattern.
Comment 9•10 years ago
|
||
stephany: That's also what we are saying.... I'm not sure we're talking about the same thing here.... According to the specs, they in fact DO NOT change on the lockscreen but they DO change when it's an incoming call!
we're saying that in this case, the pattern leads to confusion, so asking for some guidance and making sure this is correct, since this is confusing! Let's follow up offline. Closing this as resolved invalid for the time, since pattern in both cases is correct, but just seems confusing. Please reopen if needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Comment 10•10 years ago
|
||
We understand and are aware of and sorry for that confusion, but the lockscreen is an exception for 2.2. We do hope to be able to change it down the road.
Updated•10 years ago
|
Flags: needinfo?(whuang)
Updated•10 years ago
|
Flags: needinfo?(jcheng)
You need to log in
before you can comment on or make changes to this bug.
Description
•