Closed Bug 1126289 Opened 10 years ago Closed 10 years ago

Turn on screen sharing in nightly builds

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
2

Tracking

(firefox38 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla38
Iteration:
38.3 - 23 Feb
Tracking Flags:
Tracking Status
firefox38 --- fixed
Blocking Flags:
backlog Fx38+

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

Enable screen sharing for Loop link-generators by default.
(deleted), patch
mikedeboer
: review+
Details | Diff | Splinter Review
We should turn on screen sharing when: - We've fixed the dependencies - We're happy with the UX - The link-clicker UI has been deployed
Priority: -- → P1
Depends on: 1130356
backlog: --- → Fx38+
I think with the change of the icon, its reasonable to enable this in nightly now. Bug 1130356 is the only other issue we might want to wait for, but I think its good enough for nightly users that we can enable without that (although hopefully it'll land soon). Mike, what do you think? If not, we can just hold this patch until we're ready.
Attachment #8563312 - Flags: review?(mdeboer)
Assignee: nobody → standard8
Iteration: --- → 38.3 - 23 Feb
Points: --- → 1
Comment on attachment 8563312 [details] [diff] [review] Enable screen sharing for Loop link-generators by default. We discussed on IRC that we'll just remove the pref altogether.
Attachment #8563312 - Flags: review?(mdeboer)
Points: 1 → 2
Status: NEW → ASSIGNED
Updated patch to remove the preference completely.
Attachment #8563312 - Attachment is obsolete: true
Attachment #8563357 - Flags: review?(mdeboer)
Comment on attachment 8563357 [details] [diff] [review] Enable screen sharing for Loop link-generators by default. Review of attachment 8563357 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8563357 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/a68f15690f03
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/a68f15690f03
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: