Closed
Bug 1126334
Opened 10 years ago
Closed 10 years ago
Hello Icon should change colour when screensharing is active
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox38 fixed)
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
As per the UX, we should be changing the colour of the Hello icon on the toolbar when screensharing is active within Hello.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → standard8
Iteration: --- → 38.2 - 9 Feb
|
|
Assignee | |
Comment 1•10 years ago
|
||
This sets the icon depending on the screen share state. I've accounted for multiple rooms at the moment, which is mainly because its possible, even though it is unlikely - however it doesn't add much code complexity so seemed reasonable to do.
Attachment #8559795 -
Flags: review?(jaws)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8559795 [details] [diff] [review]
Hello Icon should change colour when screensharing is active.
Review of attachment 8559795 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/browser-loop.js
@@ +193,5 @@
> let state = "";
> if (MozLoopService.errors.size) {
> state = "error";
> + } else if (MozLoopService.screenShareActive) {
> + state = "action";
How are users supposed to know that this means screensharing is active? Does the tooltip update?
Attachment #8559795 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
I'll file a follow-up bug for the tooltips.
https://hg.mozilla.org/integration/fx-team/rev/c077e79e1771
Target Milestone: --- → mozilla38
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•