Closed Bug 1126808 Opened 10 years ago Closed 10 years ago

Mark /xpcom/build as FAIL_ON_WARNINGS

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

fix v1
(deleted), patch
froydnj
: review+
Details | Diff | Splinter Review
With bug 1126790 fixed, /xpcom/build is warning-free in my local build. Filing this bug to track marking it as FAIL_ON_WARNINGS.
Attached patch fix v1 (deleted) — — Splinter Review
Here's the patch, though of course we'll need a Try run (and likely a few warning-fixes for other platforms) before this can land.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8555878 - Flags: review?(nfroyd)
Comment on attachment 8555878 [details] [diff] [review] fix v1 Review of attachment 8555878 [details] [diff] [review]: ----------------------------------------------------------------- r=me when it compiles.
Attachment #8555878 - Flags: review?(nfroyd) → review+
Depends on: 1126923
Try run w/ Windows builds fixed (layered on top of bug 1126923's patch which has landed): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8566b4f04e3 Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ecd3b1a151f
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/9ecd3b1a151f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: