Closed
Bug 1127112
Opened 10 years ago
Closed 9 years ago
offset and margin logical properties should resolve against parent's writing mode information
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
INVALID
People
(Reporter: heycam, Assigned: heycam)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
http://dev.w3.org/csswg/css-logical-props/#logical-prop says that the offset-* and margin-* logical properties are resolved to physical properties using the parent element's writing-mode, direction and text-orientation properties, but we are resolving them against the current element's writing mode properties.
Assignee | ||
Updated•10 years ago
|
Blocks: writing-mode
Assignee | ||
Comment 1•10 years ago
|
||
David, how should I be interpreting "parent element" in the spec? From within nsCSS{Compressed,Expanded}DataBlock::MapRuleInfoInto we don't know what element we are resolving style for. If "parent element" is to be interpreted literally, then using the parent style context seems wrong for cases where we don't have a 1:1 mapping of element to style context or if we are computing style for a pseudo-element. Should I instead squint and assume it means "parent box"?
Assignee: nobody → cam
Status: NEW → ASSIGNED
Flags: needinfo?(dbaron)
Assignee | ||
Comment 2•10 years ago
|
||
I'm curious too whether any of our existing use of logical margin properties in chrome will break. Pushed a try run (which will at least fail on test_logical_properties.html until I fix that): https://treeherder.mozilla.org/#/jobs?repo=try&revision=39db26bf003a
Comment 3•10 years ago
|
||
You should assume that it means the thing we have the parent style context set to; we set the parent style context much more carefully than the spec says anything about "parent".
Flags: needinfo?(dbaron)
Assignee | ||
Comment 4•10 years ago
|
||
Given the response in this thread https://lists.w3.org/Archives/Public/www-style/2015Jan/thread.html#msg576 I'm not going to make this change for now.
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Updated•8 years ago
|
Blocks: css-logical-props
You need to log in
before you can comment on or make changes to this bug.
Description
•