Closed
Bug 112715
Opened 23 years ago
Closed 23 years ago
Implement HTML Radio button in XBL
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.0
People
(Reporter: bryner, Assigned: bryner)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
pavlov
:
review+
bugs
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
john
:
review+
asa
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
The HTML radiobutton control should be implemented in XBL using XUL radiobuttons.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
Assignee | ||
Comment 1•23 years ago
|
||
Work on XBL form controls is ongoing in the tree, but will not be completed for
0.9.8. -> 0.9.9.
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Assignee | ||
Comment 2•23 years ago
|
||
XBL form controls will not be turned on for 0.9.9. -> 1.0.
Target Milestone: mozilla0.9.9 → mozilla1.0
Updated•23 years ago
|
Keywords: mozilla1.0+
Assignee | ||
Comment 3•23 years ago
|
||
Closing out "Implement <blah> in XBL" bugs where we have an implementation
checked in that is enabled via the XBL form controls preference in the Debug
pref panel. Please file any remaining issues as separate bugs.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 4•23 years ago
|
||
Are you sure this is fixed? Radio buttons in Bugzilla don't look anything like
the radio buttons in Prefs.
Assignee | ||
Comment 5•23 years ago
|
||
Oops, inadvertently closed this one out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•23 years ago
|
||
*** Bug 130003 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Comment 8•23 years ago
|
||
oops, forgot a file
Attachment #75353 -
Attachment is obsolete: true
Comment 9•23 years ago
|
||
Attachment #75354 -
Flags: superreview+
Assignee | ||
Comment 10•23 years ago
|
||
oops, previous patch had a typo.
Attachment #75354 -
Attachment is obsolete: true
Comment 11•23 years ago
|
||
Attachment #75355 -
Flags: superreview+
Updated•23 years ago
|
Attachment #75354 -
Flags: superreview+
Comment 12•23 years ago
|
||
Comment on attachment 75355 [details] [diff] [review]
another new patch
r=pavlov
Attachment #75355 -
Flags: review+
Assignee | ||
Comment 13•23 years ago
|
||
I missed some major problems with my last patch:
- I didn't suppress construction of the GfxRadioControlFrame, so the XBL widget
wasn't actually being used.
- Need to remove radio button rules in xbl-forms.css that were copied from
layout/html/document/src/forms.css.
- Need to import radio.css from layout/html/forms/resources/skin/forms.css
- Need to apply the XUL namespace to style rules for XUL elements in radio.css
Comment 14•23 years ago
|
||
Comment on attachment 75475 [details] [diff] [review]
fix some major problems
sr=jst
Attachment #75475 -
Flags: superreview+
Comment 15•23 years ago
|
||
Comment on attachment 75475 [details] [diff] [review]
fix some major problems
r=jkeiser
Attachment #75475 -
Flags: superreview+ → review+
Comment 16•23 years ago
|
||
Comment on attachment 75475 [details] [diff] [review]
fix some major problems
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75475 -
Flags: superreview+
Attachment #75475 -
Flags: approval+
Assignee | ||
Comment 17•23 years ago
|
||
Checked in.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Updated•23 years ago
|
QA Contact: madhur → tpreston
You need to log in
before you can comment on or make changes to this bug.
Description
•