Closed Bug 112724 Opened 23 years ago Closed 23 years ago

Remove duplicate copies of messenger's contents.rdf

Categories

(MailNews Core :: Simple MAPI, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.7

People

(Reporter: mscott, Assigned: mscott)

References

Details

Attachments

(1 file)

I'm trying to remove all our extra copies of messenger's contents.rdf file to reduce complexity and reduce regressions. Currently we have 4 copies of this file and if you forget to change one of them you could break something =). The 4 copies are: 1) mailnews\base\resources\content\contents.rdf (the primary copy) 2) mailnews\mapi\resources\content (mapi adds and overlay + everything in the primary copy) 3) the commercial tree base\resources\content has one 4) the commercial tree mapi directory has one. Bugscape Bug #11194 tracks 3 and 4. This patch is to remove (2) leaving us with just the one copy of contents.rdf for the messenger package. To fix this, I recently discovered that we can create our own chrome packages and put them in messenger.jar. A chrome package can have its own contents.rdf file without sharing the one used by the messenger chrome space. For the simple mapi chrome, I called this new name space "messenger-mapi". So all your chrome resources are now referenced as "chrome://messenger-mapi/content/foo.xul" Posting a patch to show what I did.
Attached patch the fix (deleted) — Splinter Review
These changes create a new chrome package called "messenger-mapi". The contents.rdf file for this new chrome package only has one overlay defined in it. So I took out all the duplicate entries from messenger's contents.rdf. the mail.jst and langenus.jst changes are to make sure this new chrome package gets registered as part of the packager for release builds.
*** Bug 102560 has been marked as a duplicate of this bug. ***
Comment on attachment 59767 [details] [diff] [review] the fix sr=sspitzer are the same changes going in for the ns tree?
Attachment #59767 - Flags: superreview+
turns out srilatha is on vacation. I got a temporary r=bienvenu and when she gets back I'll go over it with her to make sure she's okay with the changes to.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.7
this has been checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified on trunk 2002042510
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: