Closed
Bug 1127378
Opened 10 years ago
Closed 10 years ago
Investigate why PluginWidgetParent::RecvGetNativePluginPort is failure prone
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(e10sm5+)
RESOLVED
WORKSFORME
mozilla38
| Tracking | Status | |
|---|---|---|
| e10s | m5+ | --- |
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(5 obsolete files)
#2 top KillHard cause (see parent bug), however this call can't fail. So the failure is likely in the routing to PluginWidgetParent.
mozilla::plugins::PPluginWidgetChild::SendGetNativePluginPort(unsigned int *)
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginWidgetParent.cpp#166
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jmathies
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
This appears to be bad shutdown order related when we shut down a widget from the parent side.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8557911 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8558113 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8558117 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•10 years ago
|
||
In the current code, PluginWidgetChild doesn't know about tab teardown until PluginWidgetChild::ActorDestroy() gets called. This may be too late in the shutdown sequence, it looks like messages from the proxy leak over between ~PluginWidgetParent() and PluginWidgetChild::ActorDestroy(), causing child aborts.
So lets shutdown the proxy sooner to see if it helps.
Attachment #8558126 -
Attachment is obsolete: true
Attachment #8558477 -
Flags: review?(aklotz)
|
||
Updated•10 years ago
|
Attachment #8558477 -
Flags: review?(aklotz) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
|
Assignee | |
Comment 8•10 years ago
|
||
|
||
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
|
Assignee | |
Comment 10•10 years ago
|
||
I think I'll back this out for a day or so, it may have caused bug 1130734.
|
|
Assignee | |
Comment 11•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/bca7d6e77486
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bdf571458b0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 12•10 years ago
|
||
Merge of backout: https://hg.mozilla.org/mozilla-central/rev/bca7d6e77486
|
|
Assignee | |
Comment 13•10 years ago
|
||
Not showing up anymore. One of the other fixes must have tweaked this one as well.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → WORKSFORME
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8558477 -
Attachment is obsolete: true
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•