Closed
Bug 1127613
Opened 10 years ago
Closed 10 years ago
TabsPanel reanimates when switching between tabs tab types
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox38 verified, fennec38+)
VERIFIED
FIXED
Firefox 38
People
(Reporter: mcomella, Assigned: fedepaol)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
1) Open the TabsPanel
2) Switch the tabs tray to private
Expected: Does not animate
Actual: Animates
NI Martyn to make sure he sees this. Let's make sure we didn't uplift this!
Flags: needinfo?(mhaigh)
Comment 1•10 years ago
|
||
I can't reproduce this - can you give me more info about what branch you're seeing this on and what device?
Flags: needinfo?(mhaigh) → needinfo?(michael.l.comella)
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Martyn Haigh (:mhaigh) from comment #1)
> I can't reproduce this - can you give me more info about what branch you're
> seeing this on and what device?
fx-team from yesterday, but it wasn't in yesterday's Nightly - liuche could also repro with her build.
Flags: needinfo?(michael.l.comella)
Comment 3•10 years ago
|
||
Regression window wanted:
fx-team:
good build: 1422552036
bad build: 1422557070
pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=65f735ba947e&tochange=982fcfb63679
Updated•10 years ago
|
Reporter | ||
Comment 4•10 years ago
|
||
Federico, can you take a look at this?
Assignee: mhaigh → fedepaol
No longer blocks: new-tablet-v1
Status: NEW → ASSIGNED
Flags: needinfo?(fedepaol)
Assignee | ||
Comment 5•10 years ago
|
||
Done! Sorry for causing so much trouble..
Note: could not add mHeaderVisible = true directly in prepareToShow() because it had to be flipped after dispatchLayoutChange.
For that reason I had to add it also in prepareToDrag
Flags: needinfo?(fedepaol)
Attachment #8558090 -
Flags: review?(michael.l.comella)
Reporter | ||
Updated•10 years ago
|
Attachment #8558090 -
Flags: review?(michael.l.comella) → review?(wjohnston)
Updated•10 years ago
|
Attachment #8558090 -
Flags: review?(wjohnston) → review+
Updated•10 years ago
|
tracking-fennec: ? → 38+
Reporter | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Comment 8•10 years ago
|
||
TabsPanel does not animate when switching between normal and private tabs, so:
Verified as fixed on:
Device: Nexus 5 (Android 5.0.1)
Build: Firefox for Android 38.0a1 (2015-02-19)
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•