AnAkkk Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150130004739

Steps to reproduce:

I'm on ArchLinux 64bit with a package from https://bbs.archlinux.org/viewtopic.php?id=117157
I'm using firefox dev edition and it started crashing after the package maintainer enabled GTK3.
It may be related to gfx.canvas.azure.backends (=skia), layers.acceleration.force-enabled(=true) and layers.offmainthreadcomposition.enabled(=true), although I haven't tried to find which one yet.


Actual results:

#0  0x00007f0c16e990d9 in raise () from /usr/lib/libpthread.so.0                                                                                                                                                                         
#1  0x00007f0c0967eaa0 in nsProfileLock::FatalSignalHandler(int, siginfo_t*, void*) () from /usr/lib/firefox-developer-edition/libxul.so                                                                                                     
#2  <signal handler called>                                                                                                                                                                                                                     
#3  0x00007f0c13eefec0 in cairo_new_path () from /usr/lib/libcairo.so.2                                                                                                                                                                             
#4  0x00007f0c0a4cf16e in moz_gtk_widget_paint () from /usr/lib/firefox-developer-edition/libxul.so                                                                                                                                                     
#5  0x00007f0c0a4d61c7 in nsNativeThemeGTK::DrawWidgetBackground(nsRenderingContext*, nsIFrame*, unsigned char, nsRect const&, nsRect const&) ()                                                                                                             
   from /usr/lib/firefox-developer-edition/libxul.so
#6  0x00007f0c09f119a9 in nsCSSRendering::PaintBackgroundWithSC(nsPresContext*, nsRenderingContext&, nsIFrame*, nsRect const&, nsRect const&, nsStyleContext*, nsStyleBorder const&, unsigned int, nsRect*, int) () from /usr/lib/firefox-developer-edition/libxul.so
#7  0x00007f0c09f10f5a in nsCSSRendering::PaintBackground(nsPresContext*, nsRenderingContext&, nsIFrame*, nsRect const&, nsRect const&, unsigned int, nsRect*, int) ()
   from /usr/lib/firefox-developer-edition/libxul.so
#8  0x00007f0c0a51001a in nsButtonFrameRenderer::PaintBorderAndBackground(nsPresContext*, nsRenderingContext&, nsRect const&, nsRect const&, unsigned int) ()
   from /usr/lib/firefox-developer-edition/libxul.so
#9  0x00007f0c0a50ff8f in nsDisplayButtonBorderBackground::Paint(nsDisplayListBuilder*, nsRenderingContext*) () from /usr/lib/firefox-developer-edition/libxul.so
#10 0x00007f0c09ed4fb5 in mozilla::FrameLayerBuilder::PaintItems(nsTArray<mozilla::FrameLayerBuilder::ClippedDisplayItem>&, nsIntRect const&, gfxContext*, nsRenderingContext*, nsDisplayListBuilder*, nsPresContext*, nsIntPoint const&, float, float, int) () from /usr/lib/firefox-developer-edition/libxul.so
#11 0x00007f0c09ed3cab in mozilla::FrameLayerBuilder::DrawPaintedLayer(mozilla::layers::PaintedLayer*, gfxContext*, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*) () from /usr/lib/firefox-developer-edition/libxul.so
#12 0x00007f0c087251b8 in mozilla::layers::ClientPaintedLayer::PaintThebes() () from /usr/lib/firefox-developer-edition/libxul.so
#13 0x00007f0c08726cfd in mozilla::layers::ClientPaintedLayer::RenderLayerWithReadback(mozilla::layers::ReadbackProcessor*) () from /usr/lib/firefox-developer-edition/libxul.so
#14 0x00007f0c08729f37 in mozilla::layers::ClientContainerLayer::RenderLayer() () from /usr/lib/firefox-developer-edition/libxul.so
#15 0x00007f0c08729f37 in mozilla::layers::ClientContainerLayer::RenderLayer() () from /usr/lib/firefox-developer-edition/libxul.so
#16 0x00007f0c08722d3a in mozilla::layers::ClientLayerManager::EndTransactionInternal(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) () from /usr/lib/firefox-developer-edition/libxul.so
#17 0x00007f0c08726b6e in mozilla::layers::ClientLayerManager::EndTransaction(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) () from /usr/lib/firefox-developer-edition/libxul.so
#18 0x00007f0c09f07ddb in nsDisplayList::PaintRoot(nsDisplayListBuilder*, nsRenderingContext*, unsigned int) () from /usr/lib/firefox-developer-edition/libxul.so
#19 0x00007f0c09efa1d6 in nsLayoutUtils::PaintFrame(nsRenderingContext*, nsIFrame*, nsRegion const&, unsigned int, unsigned int) () from /usr/lib/firefox-developer-edition/libxul.so
#20 0x00007f0c09f3115d in PresShell::Paint(nsView*, nsRegion const&, unsigned int) () from /usr/lib/firefox-developer-edition/libxul.so
#21 0x00007f0c09e2eab1 in nsViewManager::ProcessPendingUpdatesPaint(nsIWidget*) () from /usr/lib/firefox-developer-edition/libxul.so
#22 0x00007f0c09e2caf6 in nsViewManager::ProcessPendingUpdatesForView(nsView*, bool) () from /usr/lib/firefox-developer-edition/libxul.so
#23 0x00007f0c09eb4768 in nsRefreshDriver::Tick(long, mozilla::TimeStamp) () from /usr/lib/firefox-developer-edition/libxul.so
#24 0x00007f0c09287435 in nsRefreshDriver::DoTick() () from /usr/lib/firefox-developer-edition/libxul.so
#25 0x00007f0c09287517 in nsRefreshDriver::FinishedWaitingForTransaction() () from /usr/lib/firefox-developer-edition/libxul.so
#26 0x00007f0c0875179c in mozilla::layers::CompositorChild::RecvDidComposite(unsigned long const&, unsigned long const&) () from /usr/lib/firefox-developer-edition/libxul.so
#27 0x00007f0c083f2d3e in mozilla::layers::PCompositorChild::OnMessageReceived(IPC::Message const&) () from /usr/lib/firefox-developer-edition/libxul.so
#28 0x00007f0c0a3887c4 in mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) () from /usr/lib/firefox-developer-edition/libxul.so
#29 0x00007f0c0a388711 in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message const&) () from /usr/lib/firefox-developer-edition/libxul.so
---Type <return> to continue, or q <return> to quit---
#30 0x00007f0c0a3885eb in mozilla::ipc::MessageChannel::OnMaybeDequeueOne() () from /usr/lib/firefox-developer-edition/libxul.so
#31 0x00007f0c0a384738 in MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) () from /usr/lib/firefox-developer-edition/libxul.so
#32 0x00007f0c09c77c26 in MessageLoop::DoWork() () from /usr/lib/firefox-developer-edition/libxul.so
#33 0x00007f0c0a38822b in mozilla::ipc::DoWorkRunnable::Run() () from /usr/lib/firefox-developer-edition/libxul.so
#34 0x00007f0c09c2efa8 in nsThread::ProcessNextEvent(bool, bool*) () from /usr/lib/firefox-developer-edition/libxul.so
#35 0x00007f0c09c3f75d in NS_ProcessNextEvent(nsIThread*, bool) () from /usr/lib/firefox-developer-edition/libxul.so
#36 0x00007f0c09c7982b in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) () from /usr/lib/firefox-developer-edition/libxul.so
#37 0x00007f0c0a384132 in MessageLoop::Run() () from /usr/lib/firefox-developer-edition/libxul.so
#38 0x00007f0c0a4cc7ba in nsBaseAppShell::Run() () from /usr/lib/firefox-developer-edition/libxul.so
#39 0x00007f0c0a56b6ee in nsAppStartup::Run() () from /usr/lib/firefox-developer-edition/libxul.so
#40 0x00007f0c0a57e3dc in XREMain::XRE_mainRun() () from /usr/lib/firefox-developer-edition/libxul.so
#41 0x00007f0c0a57c91c in XREMain::XRE_main(int, char**, nsXREAppData const*) () from /usr/lib/firefox-developer-edition/libxul.so
#42 0x00007f0c0a57c71f in XRE_main () from /usr/lib/firefox-developer-edition/libxul.so
#43 0x0000000000410284 in do_main(int, char**, nsIFile*) ()
#44 0x000000000040c366 in main ()

	Kevin Brosnan [Ex-Mozilla]
	Comment 1 • 9 years ago

It would be useful to get a backtrace from a recent nightly, unfortunately that requires a build from source. The GTK3 code is not stable and building off the Aurora branch means that that build only gets changes once every 6 weeks. https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

	Jan Alexander Steffens [:heftig]
	Comment 2 • 9 years ago

(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> It would be useful to get a backtrace from a recent nightly, unfortunately
> that requires a build from source. The GTK3 code is not stable and building
> off the Aurora branch means that that build only gets changes once every 6
> weeks. https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

Wasn't the elm branch used to build GTK3 nightlies? It appears those builds were stopped early this month.

	AnAkkk Reporter
	Comment 3 • 9 years ago

From my testing it only seems to crash when OMTC is enabled (layers.acceleration.force-enabled/layers.offmainthreadcomposition.enabled) which was already the case 3-4 months ago when the same ArchLinux package had GTK3 enabled.

	Kevin Brosnan [Ex-Mozilla]
	Comment 4 • 9 years ago

I knew about elm, the builds approaching a month old is the reason I mentioned building yourself. I suspect glandium and others have been busy.

	Ilya
	Comment 5 • 9 years ago

I'm also on Arch Linux x86_64. I use Firefox 36 b6 compiled according to the script https://aur.archlinux.org/packages/firefox-gtk3 (excluding using patch mozilla-858919.patch) and with using all above mentioned settings (gfx.canvas.azure.backends (=skia), layers.acceleration.force-enabled(=true) and layers.offmainthreadcomposition.enabled(=true)) I have no crashes or any unstable work. I have built firefox with clang 3.5.1 and even used maximum optimized compilation flags for building - all is fine.
My suggestion - try to rebuild firefox from source.

	AnAkkk Reporter
	Comment 6 • 9 years ago

(In reply to Ilya from comment #5)
> I'm also on Arch Linux x86_64. I use Firefox 36 b6 compiled according to the
> script https://aur.archlinux.org/packages/firefox-gtk3 (excluding using
> patch mozilla-858919.patch) and with using all above mentioned settings
> (gfx.canvas.azure.backends (=skia), layers.acceleration.force-enabled(=true)
> and layers.offmainthreadcomposition.enabled(=true)) I have no crashes or any
> unstable work. I have built firefox with clang 3.5.1 and even used maximum
> optimized compilation flags for building - all is fine.
> My suggestion - try to rebuild firefox from source.

layers.acceleration.force-enabled and layers.offmainthreadcomposition.enabled won't do anything if you aren't using a patch or didn't set the MOZ_USE_OMTC=1 environment variable before launching firefox.

	Ilya
	Comment 7 • 9 years ago

(In reply to AnAkkk from comment #6)
> layers.acceleration.force-enabled and
> layers.offmainthreadcomposition.enabled won't do anything if you aren't
> using a patch or didn't set the MOZ_USE_OMTC=1 environment variable before
> launching firefox.

Yes, you are right! Now firefox often crashes with segmentation fault.

	AnAkkk Reporter
	Comment 8 • 9 years ago

I guess this is going to be a problem for the GTK3 builds now that OMTC was enabled in nightly.

	Nicolas Silva [:nical]
	Comment 9 • 9 years ago

Right now I am running into bug 1063359 which prevents me from getting this crash (gecko doesn't start at all). Are there non-Arch users running into this ? I ask because I Firefox on Arch is built with some specific options (using system libraries etc.), although I don't know for sure how different things are for the gtk3 build.

	Jan Alexander Steffens [:heftig]
	Comment 10 • 9 years ago

The build I maintain at http://pkgbuild.com/~heftig/packages/firefox-developer-edition/ also suffers from this issue. The only system lib configured is cairo (as required for cairo-gtk3).

	Lee Salzman [:lsalzman] Assignee
	Comment 12 • 9 years ago

Fixed a possible case where XShm might not be available.

	Lee Salzman [:lsalzman] Assignee
	Comment 13 • 9 years ago

Fixed accidental debug code left in earlier patch

	Jeff Muizelaar [:jrmuizel]
	Comment 14 • 9 years ago

Comment on attachment 8598157 [details] [diff] [review]
fixes for using Skia and OMTC with GTK3

Review of attachment 8598157 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/2D.h
@@ +883,5 @@
>  
> +  /**
> +   * Whether the current clip is either a path or anti-aliased rect.
> +   */
> +  virtual bool IsComplexClip() const { return true; }

I like HasComplexClip better because it IsComplexClip makes it seem like the we're asking whether the DrawTarget is a complex clip.

::: gfx/2d/DrawTargetSkia.cpp
@@ +163,5 @@
> +  *aData = reinterpret_cast<uint8_t*>(bitmap.getPixels());
> +  *aSize = IntSize(bitmap.width(), bitmap.height());
> +  *aStride = int32_t(bitmap.rowBytes());
> +  *aFormat = SkiaColorTypeToGfxFormat(bitmap.colorType());
> +  return true;  

There's a bunch of places where there's trailing white space in the patch. These show up really obviously in bugzilla's review view.

::: widget/gtk/nsNativeThemeGTK.cpp
@@ +744,5 @@
> +      if (aScaleFactor != 1) {
> +          dt->SetTransform(Matrix::Scaling(aScaleFactor, aScaleFactor));
> +      }
> +
> +      cairo_t* cr = (cairo_t*)dt->GetNativeSurface(NativeSurfaceType::CAIRO_CONTEXT);

We always want to use system cairo here so it should instead be something like:

cairo_t *cr = cairo_create_image_surface_for_data(...)
cairo_scale(cr, aScaleFactor);

moz_gtk_widget_paint(cr);

@@ +786,5 @@
> +          }
> +        }
> +      }
> +      
> +      dataSurface->Unmap();

I believe we should Unmap the surface before we can use it in DrawSurface or CopySurface.

@@ +984,5 @@
>    renderer.Draw(ctx, drawingRect.Size(), rendererFlags, colormap);
>  #else 
> +  DrawTarget* dt = aContext->GetDrawTarget();
> +  cairo_t *cr = (cairo_t*)dt->GetNativeSurface(NativeSurfaceType::CAIRO_CONTEXT);
> +  if (cr) {

I think we should just drop this path completely because it won't work with in-tree cairo.

	Lee Salzman [:lsalzman] Assignee
	Comment 16 • 9 years ago

Fixed potential bug related to notification of changes to draw target, added support for Cairo xlib surfaces, and updated to work with the newer tree and system Cairo patch.

	Lee Salzman [:lsalzman] Assignee
	Comment 17 • 9 years ago

Fix missing HelpersCairo.cpp

	Lee Salzman [:lsalzman] Assignee
	Comment 18 • 9 years ago

Use borrowed contexts instead of GetNativeSurface

	Jeff Muizelaar [:jrmuizel]
	Comment 19 • 9 years ago

Comment on attachment 8599938 [details] [diff] [review]
fixes for using Skia and OMTC with GTK3

Review of attachment 8599938 [details] [diff] [review]:
-----------------------------------------------------------------

There's still some trailing in whitespace

::: gfx/2d/moz.build
@@ +79,4 @@
>          'image_operations.cpp', # Uses _USE_MATH_DEFINES
>      ]
>      EXPORTS.mozilla.gfx += [
> +        'HelpersCairo.h',

These shouldn't be needed anymore.

::: widget/gtk/nsNativeThemeGTK.cpp
@@ +829,5 @@
> +      cairo_surface_t* surf =
> +        cairo_image_surface_create_for_data(map.mData, GfxFormatToCairoFormat(format),
> +                                            aDrawSize.width, aDrawSize.height, map.mStride);
> +      cairo_t* cr = nullptr;
> +      if (!NS_WARN_IF(!surf)) {

This style of NS_WARN_IF is not super common in the code base. It seems reasonble here though.

	Lee Salzman [:lsalzman] Assignee
	Comment 20 • 9 years ago

Remove trailing whitespace

	Lee Salzman [:lsalzman] Assignee
	Comment 21 • 9 years ago

Refreshed patch to not depend on harfbuzz rename changes

	Mike Hommey [:glandium]
	Comment 22 • 9 years ago

This patch fails to build:

/builds/slave/try-l64-0000000000000000000000/build/src/widget/nsIWidget.h:1659:18: error: 'virtual void nsIWidget::EndRemoteDrawing(mozilla::gfx::DrawTarget*, nsIntRegion&)' was hidden [-Werror=overloaded-virtual]
/builds/slave/try-l64-0000000000000000000000/build/src/widget/nsBaseWidget.h:165:16: error: by 'virtual void nsBaseWidget::EndRemoteDrawing()' [-Werror=overloaded-virtual]
gmake[5]: *** [nsBaseWidget.o] Error 1
gmake[5]: *** Waiting for unfinished jobs....
/builds/slave/try-l64-0000000000000000000000/build/src/widget/nsIWidget.h:1659:18: error: 'virtual void nsIWidget::EndRemoteDrawing(mozilla::gfx::DrawTarget*, nsIntRegion&)' was hidden [-Werror=overloaded-virtual]
/builds/slave/try-l64-0000000000000000000000/build/src/widget/nsBaseWidget.h:165:16: error: by 'virtual void nsBaseWidget::EndRemoteDrawing()' [-Werror=overloaded-virtual]
gmake[5]: *** [Unified_cpp_widget0.o] Error 1
gmake[4]: *** [widget/target] Error 2

	Lee Salzman [:lsalzman] Assignee
	Comment 23 • 9 years ago

(In reply to Mike Hommey [:glandium] from comment #22)
> This patch fails to build:
> 
> /builds/slave/try-l64-0000000000000000000000/build/src/widget/nsIWidget.h:
> 1659:18: error: 'virtual void
> nsIWidget::EndRemoteDrawing(mozilla::gfx::DrawTarget*, nsIntRegion&)' was
> hidden [-Werror=overloaded-virtual]
> /builds/slave/try-l64-0000000000000000000000/build/src/widget/nsBaseWidget.h:
> 165:16: error: by 'virtual void nsBaseWidget::EndRemoteDrawing()'
> [-Werror=overloaded-virtual]
> gmake[5]: *** [nsBaseWidget.o] Error 1
> gmake[5]: *** Waiting for unfinished jobs....
> /builds/slave/try-l64-0000000000000000000000/build/src/widget/nsIWidget.h:
> 1659:18: error: 'virtual void
> nsIWidget::EndRemoteDrawing(mozilla::gfx::DrawTarget*, nsIntRegion&)' was
> hidden [-Werror=overloaded-virtual]
> /builds/slave/try-l64-0000000000000000000000/build/src/widget/nsBaseWidget.h:
> 165:16: error: by 'virtual void nsBaseWidget::EndRemoteDrawing()'
> [-Werror=overloaded-virtual]
> gmake[5]: *** [Unified_cpp_widget0.o] Error 1
> gmake[4]: *** [widget/target] Error 2

Apparently try was using more stringent error warnings than my local mach builds. Working on fixing this.

	Lee Salzman [:lsalzman] Assignee
	Comment 24 • 9 years ago

Fix some try server build issues: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6832f85f55b1

	AnAkkk Reporter
	Comment 25 • 9 years ago

Any chance this can make it before Aurora gets v40 ? Seem to be in 2 days.

	Kevin Brosnan [Ex-Mozilla]
	Comment 26 • 9 years ago

Firefox 41 opened for development today so it will not be making 40. I doubt there are any plans to uplift this since the gtk3 builds are tinderbox only.

	Pulsebot
	Comment 27 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8538bc4d2cbd

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 28 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/8538bc4d2cbd