Closed Bug 1128180 Opened 10 years ago Closed 10 years ago

User Timing shim causes errors when target implementation exists

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S5 (6feb)
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: Eli, Assigned: Eli)

References

Details

(Keywords: perf)

Attachments

(1 file)

The User Timing shim causes errors in requirejs applications when the proper User Timing API exists. This is because the script erroneously returns when the API exists, causing the requirejs loader at the end of the script to not execute.
David, would you review my shared JS code change here?
Attachment #8557508 - Flags: review?(dflanagan)
Comment on attachment 8557508 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27832 Looks good to me. Thanks for explaining that it was just a 1-line diff with indentation changes. Too bad that github isn't better at detecting that.
Attachment #8557508 - Flags: review?(dflanagan) → review+
Comment on attachment 8557508 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27832 Need to land this in v2.2 *before* User Timing so that User Timing landing will not cause Gaia test failures. [Bug caused by] (feature/regressing bug #): 782751 [User impact] if declined: no performance testing using Raptor on v2.2 [Testing completed]: this patch is for test code [Risk to taking this patch] (and alternatives if risky): low, this patch fixes an error in capturing performance marks and measures [String changes made]: n/a
Attachment #8557508 - Flags: approval-gaia-v2.2?(bbajaj)
Attachment #8557508 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
Whiteboard: checkin-needed
Whiteboard: checkin-needed
Target Milestone: --- → 2.2 S5 (6feb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: