SetProperty DiscoveryTimeout failed due to missing property length.

Comment on attachment 8557816 [details] [diff] [review] [BlueDroid] Set Bluetooth discoverable timeout properly in 'Convert' function of Bluetooth interface. (v1) Review of attachment 8557816 [details] [diff] [review]: ----------------------------------------------------------------- What's the problem that the original code? Could you please write the reason?

hmm... I guess the original code may crash, right? This seems to be a bug.

- Bring the change to Bluetooth2 as well - Add reviewer's name to commit message - Convert to hg format

Comment on attachment 8559004 [details] [diff] [review] (for v2.2) [BlueDroid] Set Bluetooth discoverable timeout properly in 'Convert' function of Bluetooth interface. (v1) Review of attachment 8559004 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.

(In reply to Shawn Huang [:shawnjohnjr] from comment #3) > hmm... I guess the original code may crash, right? This seems to be a bug. With this bug, Bluetooth adapter can't set discoverable timeout. The reproduce rate is 100%. It also have a chance to crash the b2g process since the void ptr point to an incorrect address. (It did crash few times during the experiment. However, it doesn't mean it would happen every time.)

- Rebase - Add reviewer's name to commit message.

- Rebase - Add reviewer's name to commit message

Comment on attachment 8564042 [details] [diff] [review] (for v2.1) [BlueDroid] Set Bluetooth discoverable timeout properly in 'Convert' function of Bluetooth interface. (v2), r=shuang NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] > Bug caused by (feature/regressing bug #): It's a follow-up bug of Bug 1060229. > User impact if declined: This MDN page [1] indicates that BluetoothAdapter can set discoverable timeout by 'setDiscoverableTimeout(timeout)'. However, the function isn't functional on FxOS v2.1. [1] https://developer.mozilla.org/en-US/docs/Web/API/BluetoothAdapter Although 'setDiscoverableTimeout()' hasn't been used by any build-in gaia app yet, it still a part of Bluetooth Web API. It means it have to be tested by MCTS (Firefox OS Certification Testsuite). Therefore, it will block MCTS bug in future. > Testing completed: Call this function in setting app and print 'BluetoothAdapter.discoverableTimeout' through adb logcat. > Risk to taking this patch (and alternatives if risky): 'BluetoothAdapter.setDiscoverableTimeout()' is a rarely used function and it'll be removed from Bluetooth API v2 [2] on FxOS v3. > String or UUID changes made by this patch: no

Comment on attachment 8564041 [details] [diff] [review] (for v2.2) [BlueDroid] Set Bluetooth discoverable timeout properly in 'Convert' function of Bluetooth interface. (v1), r=shuang NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. The patch was cherry-pick from v2.1 patch. Copy [Approval Request Comment] from #comment 10 [Approval Request Comment] > Bug caused by (feature/regressing bug #): It's a follow-up bug of Bug 1060229. > User impact if declined: This MDN page [1] indicates that BluetoothAdapter can set discoverable timeout by 'setDiscoverableTimeout(timeout)'. However, the function isn't functional on FxOS v2.2. [1] https://developer.mozilla.org/en-US/docs/Web/API/BluetoothAdapter Although 'setDiscoverableTimeout()' hasn't been used by any build-in gaia app yet, it still a part of Bluetooth Web API. It means it have to be tested by MCTS (Firefox OS Certification Testsuite). Therefore, it will block MCTS bug in future. > Testing completed: Call this function in setting app and print 'BluetoothAdapter.discoverableTimeout' through adb logcat. > Risk to taking this patch (and alternatives if risky): 'BluetoothAdapter.setDiscoverableTimeout()' is a rarely used function and it'll be removed from Bluetooth API v2 [2] on FxOS v3. > String or UUID changes made by this patch: no

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/028cf76de8d7 https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/d8d79a4c2571

Comment on attachment 8571163 [details] [diff] [review] (for master) [BlueDroid] Set Bluetooth discoverable timeout properly in 'Convert' function of Bluetooth interface. (v1), r=shuang Hi Shawn, Since Bluetooth daemon might not be activated by default, the Bluetooth HAL helper is still needed on master branch. I'd like to apply this patch to master branch. Do you think it appropriate ?

Oh. Please don't ni me using personal account.

(In reply to Jamin Liu [:jaliu] from comment #15) > Comment on attachment 8571163 [details] [diff] [review] > (for master) [BlueDroid] Set Bluetooth discoverable timeout properly in > 'Convert' function of Bluetooth interface. (v1), r=shuang > > Hi Shawn, > Since Bluetooth daemon might not be activated by default, the Bluetooth HAL > helper is still needed on master branch. > > I'd like to apply this patch to master branch. Do you think it appropriate ? Yes. Please go ahead.

Try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87acb1c26cff