Closed Bug 1128691 Opened 10 years ago Closed 10 years ago

Consolidate Silk Preference Checks into 1 location

Categories

(Core :: Graphics, defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(2 files, 1 obsolete file)

Right now we read various silk related prefs in multiple locations. Consolidate them so it's easier to ensure silk is on/off.
Refactor checks for gfxPrefs::VsyncAlignedCompositor() to just check if the mCompositorVsyncObserver exists. Also nulls out the mCompositorVsyncObserver during CompositorParent initialization.
Attachment #8558202 - Flags: review?(bgirard)
Replaces checks for gfxPrefs::TouchResampling() with sTouchDispatcher->mResamplingEnabled.
Attachment #8558203 - Flags: review?(bugmail.mozilla)
Attachment #8558203 - Attachment is obsolete: true
Attachment #8558203 - Flags: review?(bugmail.mozilla)
Attachment #8558204 - Flags: review?(bugmail.mozilla)
Attachment #8558204 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 8558202 [details] [diff] [review] Part 1: Refactor checks for gfxPrefs::VsyncAlignedCompositor Review of attachment 8558202 [details] [diff] [review]: ----------------------------------------------------------------- Is something missing in this patch? It seems to make things dead code.
Comment on attachment 8558202 [details] [diff] [review] Part 1: Refactor checks for gfxPrefs::VsyncAlignedCompositor Review of attachment 8558202 [details] [diff] [review]: ----------------------------------------------------------------- Ok, the patch context was just insufficient. Pulling up the code for mCompositorVsyncObserver makes this clear.
Attachment #8558202 - Flags: review?(bgirard) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: