Closed
Bug 1128691
Opened 10 years ago
Closed 10 years ago
Consolidate Silk Preference Checks into 1 location
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Right now we read various silk related prefs in multiple locations. Consolidate them so it's easier to ensure silk is on/off.
Assignee | ||
Comment 1•10 years ago
|
||
Refactor checks for gfxPrefs::VsyncAlignedCompositor() to just check if the mCompositorVsyncObserver exists. Also nulls out the mCompositorVsyncObserver during CompositorParent initialization.
Attachment #8558202 -
Flags: review?(bgirard)
Assignee | ||
Comment 2•10 years ago
|
||
Replaces checks for gfxPrefs::TouchResampling() with sTouchDispatcher->mResamplingEnabled.
Attachment #8558203 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8558203 -
Attachment is obsolete: true
Attachment #8558203 -
Flags: review?(bugmail.mozilla)
Attachment #8558204 -
Flags: review?(bugmail.mozilla)
Updated•10 years ago
|
Attachment #8558204 -
Flags: review?(bugmail.mozilla) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8558202 [details] [diff] [review]
Part 1: Refactor checks for gfxPrefs::VsyncAlignedCompositor
Review of attachment 8558202 [details] [diff] [review]:
-----------------------------------------------------------------
Is something missing in this patch? It seems to make things dead code.
Comment 5•10 years ago
|
||
Comment on attachment 8558202 [details] [diff] [review]
Part 1: Refactor checks for gfxPrefs::VsyncAlignedCompositor
Review of attachment 8558202 [details] [diff] [review]:
-----------------------------------------------------------------
Ok, the patch context was just insufficient. Pulling up the code for mCompositorVsyncObserver makes this clear.
Attachment #8558202 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/74ec30a5de72
https://hg.mozilla.org/mozilla-central/rev/7a9bb617e461
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•