Closed
Bug 112885
Opened 23 years ago
Closed 23 years ago
Scroll bar in message pane shouldn't have border-right
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jonasj, Assigned: jonasj)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
andreww
:
review+
sspitzer
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
In navigator it is possible to move the mouse cursor all the way to the right,
press the mouse button, and scroll. In the message pane, you have to move the
cursor a bit to the left because there is a border on the right side of the
scrollbar. This is annoying.
Assignee | ||
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
This is similar to the recently fixed bug 52888, "classic skin: scrollbar
should be at right edge of window" (for navigator).
Assignee | ||
Comment 3•23 years ago
|
||
Yo! Could someone please review the patch?
Updating multiple bugs. This is a valid UI issue. Would be nice to have it fixed
if time allows.
Comment 5•23 years ago
|
||
shuehan / joe, could you review and then I'll sr?
Comment 6•23 years ago
|
||
ah, I get it now.
if I expand my 3 pane or my stand alone msg window to take up the whole
monitor, I can't move my mouse to the edge of the monitor and click and scroll
the message pane.
but I can do that once I apply the patch, at least for modern.
I'm not sure the classic changes are correct, or needed.
#messagepane doesn't define a right-border in classic (mac or windows, don't
forget about
mozilla\themes\classic\messenger\mac\mailWindow1.css
but the modern changes are fine.
for the classic changes, can you double check if they are needed? cc andreww,
so he can review the classic changes.
Assignee | ||
Comment 7•23 years ago
|
||
> I'm not sure the classic changes are correct, or needed.
> #messagepane doesn't define a right-border in classic
No, but #messagepanebox does, and that's what I removed it from. Before I did
that, I couldn't scroll the message with classic when the mouse was at the right
edge of the screen, now I can.
But it was good that you told me to doublecheck it, because that made me
discover that the thread pane has the same problem (in classic only). I guess
that that should actually be filed as a separate bug, but we might as well fix
it here.
Assignee | ||
Comment 8•23 years ago
|
||
Attachment #59870 -
Attachment is obsolete: true
Assignee | ||
Comment 9•23 years ago
|
||
Could someone review?
Comment 10•23 years ago
|
||
Comment on attachment 61870 [details] [diff] [review]
patch - fixes the bug for both message and thread pane
looks ok to me.
Attachment #61870 -
Flags: review+
Comment 11•23 years ago
|
||
Comment on attachment 61870 [details] [diff] [review]
patch - fixes the bug for both message and thread pane
r=andreww
Comment 12•23 years ago
|
||
You're going to need to re-do this patch, the CSS changed quite a bit after my
themes re-write last month.
Comment 14•23 years ago
|
||
my question would be did you test this new patch on your own build?
Assignee | ||
Comment 15•23 years ago
|
||
Tested it on on build 2001122803. Why, is there a problem with it?
Assignee | ||
Comment 16•23 years ago
|
||
andreww: ping!
Comment 17•23 years ago
|
||
Comment on attachment 63422 [details] [diff] [review]
updated patch
r=andreww - check with hewitt as well if you can.
Attachment #63422 -
Flags: review+
Assignee | ||
Comment 18•23 years ago
|
||
hewitt, can you sr=?
Assignee | ||
Comment 19•23 years ago
|
||
Seth, could you sr= this, please?
Comment 21•23 years ago
|
||
Comment on attachment 63422 [details] [diff] [review]
updated patch
sr=sspitzer
Attachment #63422 -
Flags: superreview+
Assignee | ||
Comment 22•23 years ago
|
||
Finally... thanks, Seth!
Andreww, could you check this in for me, please?
Comment 23•23 years ago
|
||
ok - Ill do it when the tree opens again for general checkins...
Assignee | ||
Comment 24•23 years ago
|
||
Andrew? Did you plan to check this in after 1.0, or did you just forget about it?
Comment 25•23 years ago
|
||
I should be able to get this in today when the tree opens. Ill send an
approval req right now.
Status: NEW → ASSIGNED
Comment 27•23 years ago
|
||
Comment on attachment 63422 [details] [diff] [review]
updated patch
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #63422 -
Flags: approval+
Comment 28•23 years ago
|
||
ok going to try to get this in today.
Comment 29•23 years ago
|
||
ok lets try again today. Several fire drills on friday kept me from doing this.
Comment 30•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 32•23 years ago
|
||
Bug 143855: a better fix would be to somehow show the border to the left of the
scrollbar.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•