Closed
Bug 1128988
Opened 10 years ago
Closed 9 years ago
[e10s] Land runAt support for commands/converters in GCLI
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P1)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(e10s+, firefox40 fixed)
RESOLVED
FIXED
Firefox 40
People
(Reporter: jwalker, Assigned: jwalker)
References
(Blocks 1 open bug)
Details
(Whiteboard: [polish-backlog][difficulty=hard])
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
tracking-e10s:
--- → ?
Comment 1•10 years ago
|
||
Was this filed right Joe? Looks like this was supposed to track, but I'm not sure. Anyway, for dev tools e10s bugs we usually track to the dte-e10s meta and mark tracking-e10s:+. Does that fit this bug?
Flags: needinfo?(jwalker)
(In reply to Jim Mathies [:jimm] from comment #1) > Was this filed right Joe? Looks like this was supposed to track, but I'm not > sure. Anyway, for dev tools e10s bugs we usually track to the dte-e10s meta > and mark tracking-e10s:+. Does that fit this bug? AIUI, this work will enable GCLI commands to work with e10s. I'll block the meta bug.
Blocks: dte10s
Assignee | ||
Comment 3•10 years ago
|
||
As jryans said, this is an e10s bug. I'm not sure what the correct meta-fu is for that, but whatever works is good for me. This bug should fix bug 1034511 and bug 1074233.
Flags: needinfo?(jwalker)
Assignee | ||
Comment 4•10 years ago
|
||
This is not complete yet, I'm working through the commands making sure they work properly, but I expect most of my changes from here to be additions, and I'd like to set the ball rolling. I've broken out and described in detail the changes here https://github.com/joewalker/gecko-dev/pull/7
Assignee: nobody → jwalker
Attachment #8565357 -
Flags: feedback?(bgrinstead)
Comment 5•9 years ago
|
||
Comment on attachment 8565357 [details] [diff] [review] 1128988.patch See comments at https://github.com/joewalker/gecko-dev/pull/7 and https://github.com/joewalker/gcli/pull/76
Attachment #8565357 -
Flags: feedback?(bgrinstead) → feedback+
Updated•9 years ago
|
Summary: Land runAt support for commands/converters in GCLI → [e10s] Land runAt support for commands/converters in GCLI
Comment 6•9 years ago
|
||
This bug blocks bug 1074233, which is M6, so I propose to track this bug for M6 as well.
Updated•9 years ago
|
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=hard]
Updated•9 years ago
|
Priority: -- → P1
Comment 7•9 years ago
|
||
Joe, can you fill us in on the status of this work? The e10s team is curious if anyone is working on this currently.
Flags: needinfo?(jwalker)
Updated•9 years ago
|
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #7) > Joe, can you fill us in on the status of this work? The e10s team is curious > if anyone is working on this currently. I'm working on it. Progress here: https://github.com/joewalker/gecko-dev/pulls Hope to be done in a few days
Flags: needinfo?(jwalker)
Assignee | ||
Comment 9•9 years ago
|
||
Reviews in progress: https://github.com/joewalker/gecko-dev/pull/8 https://github.com/joewalker/gecko-dev/pull/9 https://github.com/joewalker/gecko-dev/pull/10 https://github.com/joewalker/gecko-dev/pull/11 https://github.com/joewalker/gecko-dev/pull/12 https://github.com/joewalker/gecko-dev/pull/13 One outstanding issue: a memory leak
Attachment #8565357 -
Attachment is obsolete: true
Updated•9 years ago
|
Comment 10•9 years ago
|
||
After debugging the leaks, I found this fixed browser_dbg_cmd-dbg.js
Assignee | ||
Comment 11•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc4984e39c64
Attachment #8595290 -
Attachment is obsolete: true
Attachment #8596062 -
Attachment is obsolete: true
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8596075 [details] [diff] [review] 0001-Bug-1128988-runAt-support-for-commands-converters-r-.patch Reviews: https://github.com/joewalker/gecko-dev/pull/8 https://github.com/joewalker/gecko-dev/pull/9 https://github.com/joewalker/gecko-dev/pull/10 https://github.com/joewalker/gecko-dev/pull/11 https://github.com/joewalker/gecko-dev/pull/12 https://github.com/joewalker/gecko-dev/pull/13
Attachment #8596075 -
Flags: review+
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6ecd33215340
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment 15•9 years ago
|
||
Somehow this has caused the Inspect Element button to disappear in the Browser Toolbox (Bug 1157906). Looks like it may be a loader issue? Module `definitions` is not found at resource://gre/modules/commonjs/definitions.js "@resource:///modules/devtools/commandline/commands-index.js:82:22GcliActor<._getRequisition@resource://gre/modules/devtools/server/actors/gcli.js:245:22GcliActor<.specs<@resource://gre/modules/devtools/server/actors/gcli.js:96:12actorProto/</handler@resource://gre/modules/devtools/server/protocol.js:1006:19DSC_onPacket@resource://gre/modules/devtools/server/main.js:1456:15DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/devtools/transport/transport.js:471:9makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.js:82:14makeInfallible/<@resource://gre/modules/devtools/DevToolsUtils.js:82:14"
Depends on: 1157906
Comment 16•9 years ago
|
||
FYI, to run the Browser Toolbox in a separate window so you can see logs, you can open up a normal BT on so that the server starts and then run a separate command: ./mach run --profile /tmp/foobar -chrome chrome://browser/content/devtools/framework/toolbox-process-window.xul --purgecaches --jsconsole
Depends on: 1160345
Depends on: 1160361
Depends on: 1161131
Depends on: 1164537
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=hard] → [polish-backlog][difficulty=hard]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•