Closed Bug 1129169 Opened 10 years ago Closed 10 years ago

Country Selection broken if more than one provider exists for a region

Categories

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Avenir
x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
2015-02-10

People

(Reporter: dbialer, Assigned: scolville)

References

Details

Attachments

(1 file)

Attached image payment screen.png (deleted) —
When I submit a paid app, I am only seeing choices for Greece, Germany, Colombia and Spain. What happened to other countries such as Mexico, US, UK?
What server is this on?
production.
also notice in the screenshot, next to greece it says it is available for All Bango twice.
Looks like there are too many price currencies in the db, I'll get those cleared out. But I'm not sure why they aren't all being listed, muffinresearch do you know why?
Assignee: nobody → scolville
Priority: -- → P2
Cleaning out the price currency did it.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Although this is fixed on prod, I think its going to hit us when Boku goes live. https://marketplace.allizom.org/developers/app/compound-interest/payments/ Here's an app on stage on price tier 1: https://www.dropbox.com/s/dsqqcyzog2ru9p1/Screenshot%202015-02-03%2016.49.26.png?dl=0 Here's the api call on stage: [master] zamboni $ curl -s https://marketplace.allizom.org/api/v1/webpay/prices/1/ | python -m json.tool | grep region "region": "Rest of World", "region": 9, "region": 8, "region": 14, "region": 17, "region": 4, "region": 13, "region": 12, "region": 12, "region": 11, "region": 1, "region": 2, "region": 7, "region": 10, "region": 18, "region": 19, "region": 23, "region": 31, "region": 37, Note that region 1 (Rest of the World) doesn't show up. My guess is that its because there are two prices for Mexico. I changed the price to be 24.99, a price that doesn't occur for Boku and note that all the regions show up: https://www.dropbox.com/s/e21qp0nawo2nz0o/Screenshot%202015-02-03%2016.51.45.png?dl=0 So I think something is going wrong in that loop. You should be able to recreate this Stuart by adding price tiers for boku, just add in a price currency row for an already existing country, but change the provider to be boku.
Blocks: 987661
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Country Selection on Payments Seems Broken → Country Selection broken if more than one provider exists for a region
Yep, the problem was we're bailing out of the loop too early. PR: https://github.com/mozilla/zamboni/pull/2889
Status: REOPENED → ASSIGNED
Target Milestone: --- → 2015-02-10
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Verified as fixed in FF38(Win7) in marketplace-dev.allizom.org Postfix screencast: http://screencast.com/t/VrsmSqqQr Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: