Closed Bug 1129181 Opened 10 years ago Closed 10 years ago

Make Remote Tabs home panel split pane pull to refresh apply to the whole page, not just the tabs

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox38 fixed, fennec38+)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed
fennec 38+ ---

People

(Reporter: nalexander, Assigned: vivek, Mentored)

References

Details

Attachments

(1 file)

Right now, in landscape tablets, only the list of remote tabs has pull to refresh. There are some limitations here from the GeckoSwipeRefreshLayout. Can we make the whole panel pull to refresh?
I'd like this to track Fennec 38.
tracking-fennec: --- → ?
tracking-fennec: ? → 38+
Attached patch 1129181.patch (deleted) — Splinter Review
Linear layout moved inside GeckoSwipeRefreshLayout, now entire view (clients and tabs) can be pulled to refresh
Attachment #8562991 - Flags: review?(nalexander)
Comment on attachment 8562991 [details] [diff] [review] 1129181.patch Review of attachment 8562991 [details] [diff] [review]: ----------------------------------------------------------------- This doesn't work all that well on one of my test tablets, but it's not really us: GeckoSwipeRefreshLayout doesn't delegate all drags to the children correctly. To test this, make sure you have lots of tabs for one device, so that you can scroll the list. I'm going to land this anyway, since it's closer to what we want. ::: mobile/android/base/resources/layout/home_remote_tabs_split_plane_panel.xml @@ +41,2 @@ > > </org.mozilla.gecko.widget.GeckoSwipeRefreshLayout> nit: outdent here.
Attachment #8562991 - Flags: review?(nalexander) → review+
Assignee: nobody → vivekb.balakrishnan
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: