Closed
Bug 1129311
Opened 10 years ago
Closed 10 years ago
Don't use TabChild::sNestedTabChildMap directly
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: kanru, Assigned: kanru)
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8558958 -
Flags: review?(bugs)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8558958 [details] [diff] [review]
patch
In general I think anonymous namespaces should be still avoided, but
this is limiting the use to minimum, so fine.
I would drop // static std::map<TabId, nsRefPtr<TabChild>>& NestedTabChildMap(); from the .h
It is mystery to me why we use std::map here and not a hashtable, but that is a different bug.
Attachment #8558958 -
Flags: review?(bugs) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → kanru
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
||
Comment 4•10 years ago
|
||
Backed out for almost certainly being the cause of bug 1124046, which is nearly permafail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/88724532ac8b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla38 → ---
|
|
||
Comment 5•10 years ago
|
||
Bug 1129953, sorry.
|
|
||
Comment 6•10 years ago
|
||
This wasn't at fault. Re-landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a065c4d610e
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•