We should be able to move construct MaybeOneOf.

Needed to be explicit with types and the construct<T> method or my uses wouldn't compile.

Comment on attachment 8559341 [details] [diff] [review] Implement move construction for mozilla::MaybeOneOf Review of attachment 8559341 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me with comments below addressed. Nice to see MaybeOneOf being used elsewhere. ::: mfbt/MaybeOneOf.h @@ +50,5 @@ > public: > MaybeOneOf() : state(None) {} > ~MaybeOneOf() { destroyIfConstructed(); } > > + MaybeOneOf(MaybeOneOf &&rhs) Nit: MFBT uses Gecko style (although this file doesn't use it consistently yet) and it's probably nice to match Maybe, so: MaybeOneOf(MaybeOneOf&& aOther) @@ +65,5 @@ > + rhs.state = None; > + } > + } > + > + MaybeOneOf &operator=(MaybeOneOf &&rhs) Here I'd also match Maybe and assert against self-assignment: MaybeOneOf& operator=(MaybeOneOf&& aOther) { MOZ_ASSERT(this != &aOther, "Self-moves are prohibited"); this->~MaybeOneOf(); new(this) MaybeOneOf(Move(aOther)); return *this; }