Closed
Bug 1129573
Opened 10 years ago
Closed 10 years ago
certutil: increase the default key size to 2048 bits
Categories
(NSS :: Tools, defect)
NSS
Tools
Tracking
(Not tracked)
RESOLVED
FIXED
3.18
People
(Reporter: keeler, Assigned: keeler)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
It would be nice to increase the default key size for newly generated keys in certutil from 1024 bits to 2048.
![]() |
Assignee | |
Comment 1•10 years ago
|
||
Kai, is this sufficient, or are there other places I would need to change? Thanks.
![]() |
||
Comment 2•10 years ago
|
||
Comment on attachment 8559483 [details] [diff] [review] patch Review of attachment 8559483 [details] [diff] [review]: ----------------------------------------------------------------- Drive-by: probably going to need to update the docs here as well: https://hg.mozilla.org/projects/nss/annotate/2bffb88b1052/doc/certutil.xml#l250
Comment 3•10 years ago
|
||
(In reply to Cykesiopka from comment #2) > Drive-by: probably going to need to update the docs here as well: > https://hg.mozilla.org/projects/nss/annotate/2bffb88b1052/doc/certutil. > xml#l250 Thanks, yes please change that, too, r=kaie on changing 1024 to 2048 on that line.
Comment 4•10 years ago
|
||
Comment on attachment 8559483 [details] [diff] [review] patch That define is used to init variable "keysize", and the option to set the keysize from command line parameters changes that same variable, only, so I agree the change is sufficient to change the certutil default. r=kaie
Attachment #8559483 -
Flags: review?(kaie) → review+
Comment 5•10 years ago
|
||
David, if you need help to get this landed, please set keyword checkin-needed.
Target Milestone: --- → 3.18
![]() |
Assignee | |
Comment 6•10 years ago
|
||
Thanks for the reviews!
Attachment #8559483 -
Attachment is obsolete: true
Attachment #8568194 -
Flags: review+
![]() |
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
![]() |
Assignee | |
Comment 7•10 years ago
|
||
Looks like there was more to do (thanks, Cykesiopka). This includes the manual changes as well as the result of running `make` in doc/
Attachment #8568194 -
Attachment is obsolete: true
Attachment #8568197 -
Flags: review?(kaie)
![]() |
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Comment on attachment 8568197 [details] [diff] [review] patch v3 r=kaie
Attachment #8568197 -
Flags: review?(kaie) → review+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/2db78dcabb82
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•