Dana Keeler (she/her) (use needinfo) (:keeler for reviews) Assignee
	Description • 10 years ago

It would be nice to increase the default key size for newly generated keys in certutil from 1024 bits to 2048.

	Dana Keeler (she/her) (use needinfo) (:keeler for reviews) Assignee
	Comment 1 • 10 years ago

Kai, is this sufficient, or are there other places I would need to change? Thanks.

	:Cykesiopka
	Comment 2 • 10 years ago

Comment on attachment 8559483 [details] [diff] [review]
patch

Review of attachment 8559483 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by: probably going to need to update the docs here as well:
https://hg.mozilla.org/projects/nss/annotate/2bffb88b1052/doc/certutil.xml#l250

	Kai Engert (:KaiE:)
	Comment 3 • 10 years ago

(In reply to Cykesiopka from comment #2)
> Drive-by: probably going to need to update the docs here as well:
> https://hg.mozilla.org/projects/nss/annotate/2bffb88b1052/doc/certutil.
> xml#l250

Thanks, yes please change that, too, r=kaie on changing 1024 to 2048 on that line.

	Kai Engert (:KaiE:)
	Comment 4 • 10 years ago

Comment on attachment 8559483 [details] [diff] [review]
patch

That define is used to init variable "keysize", and the option to set the keysize from command line parameters changes that same variable, only, so I agree the change is sufficient to change the certutil default. r=kaie

	Kai Engert (:KaiE:)
	Comment 5 • 10 years ago

David, if you need help to get this landed, please set keyword checkin-needed.

	Dana Keeler (she/her) (use needinfo) (:keeler for reviews) Assignee
	Comment 6 • 10 years ago

Thanks for the reviews!

	Dana Keeler (she/her) (use needinfo) (:keeler for reviews) Assignee
	Comment 7 • 10 years ago

Looks like there was more to do (thanks, Cykesiopka).
This includes the manual changes as well as the result of running `make` in doc/

	Kai Engert (:KaiE:)
	Comment 8 • 10 years ago

Comment on attachment 8568197 [details] [diff] [review]
patch v3

r=kaie

	Kai Engert (:KaiE:)
	Comment 9 • 10 years ago

https://hg.mozilla.org/projects/nss/rev/2db78dcabb82