Description: When the user tries to search on the rocket bar without the internet connection, the settings icon with the string "No internet connection" is not right-aligned. Pre-requisite: Wi-fi and cellular data are not connected. Repro Steps: 1) Update a Flame device to BuildID: 20150204010225. 2) Set the device language in Arabic under Settings > Language. 3) Select the rocket bar on the homescreen. 4) Type any letter. 5) Observe the settings icon's location with the string "No internet connection". Actual: The settings icon is on the left side of the string. Expected: The settings icon is on the right side of the string. Device: Flame Master (319mb, full flash) Build ID: 20150204010225 Gaia: dfebaaa8aab43470f482d09d71137bab840c3ae9 Gecko: 0c2f7434c325 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Device: Flame 2.2 (319mb, full flash) BuildID: 20150204002509 Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de Gecko: 8669c26fd4a5 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Repro frequency: 100% See attached: screenshot

Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15684/

RTL triage: P2 for now, but fairly minor. It's very hard to tell that the icon is a button anyway, not clear if this has much impact.

Comment on attachment 8565370 [details] [gaia] anefzaoui:bug-1129701 > mozilla-b2g:master This seems to work well for me, and I can't find any regressions. Great work as usual Ahmed!

http://docs.taskcluster.net/tools/task-graph-inspector/#22HCdNbwTt-SAnGhydGGKw The pull request failed to pass integration tests. It could not be landed, please try again.

Ahmed - now that bug 1133971 has landed can you rebase this against master and see what gaia-try says? Thanks!

Pushed. Let's just wait and see..

Everything looks green now, so let's give it a shot.

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/db44e23e519094bf3db9b733f8f632689fdb20d1

Comment on attachment 8565370 [details] [gaia] anefzaoui:bug-1129701 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Lack of RTL support [User impact] if declined: attachment 8559470 [details] [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): very low risk to none, css RTL changes [String changes made]: none

v2.2: https://github.com/mozilla-b2g/gaia/commit/5753cde08392db5e7fbaf9367d90e0aa9f6098cd

This issue is fixed in the latest Nightly 3.0 and 2.2 Flame builds. Results: The settings icon is on the right of the text in RTL languages. Environmental Variables: Device: Flame 3.0 KK (319MB) (Full Flash) BuildID: 20150219010228 Gaia: 620aecfde85a8b093247837c55de2708e22be1e1 Gecko: 360b5f211180 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Environmental Variables: Device: Flame 2.2 KK (319MB) (Full Flash) BuildID: 20150219002504 Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4 Gecko: 159a3907b959 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Backing this out for causing multiple regressions. Bug 1134918, and bug 1134742. Master backout: https://github.com/mozilla-b2g/gaia/commit/535c18d33344d21e4189fe443db5c661d5718762 v2.2 backout: https://github.com/mozilla-b2g/gaia/commit/749eb677a819a8700b2cb3fc4d078ce377bbc460

Ahmed - is this something that you'll be able to revisit?

Nominating to block as this blocks other RTL bugs, which are now blockers.

I guess we have to find someone else here.

Alberto, can you fix the regressions and reland this patch?

Sure

Comment on attachment 8577189 [details] [gaia] albertopq:1129701-icon-search > mozilla-b2g:master Overall the code looks good. Right now we have a small problem with the search provider drop-down icon always displaying on the left (even in RTL mode). I also left question on github. Feel free to reflag me when the drop-down icon is fixed.

I just attached 2 screenshots, showing how I see the search screen in both LTR and RTL with the patch. I can see the dropdown icon at the right on RTL, and on the left on LTR. I probably misunderstood something. Could you please clarify? Thanks!

Oh, that's weird. I was seeing it always display on the left. In any case, the drop down icon (the little triangle before Yahoo search) should be on the right of the text for English, and left for Arabic. That is how it is on the current master. It looks like your patch reverses those.

Comment on attachment 8577189 [details] [gaia] albertopq:1129701-icon-search > mozilla-b2g:master LGTM! Nice work.

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

master: https://github.com/mozilla-b2g/gaia/commit/8c9cb3713ce4e222ff90d96bd05e0659c8ce5016

Please uplift to v2.2. Thanks.

This issue has been verified fail on latest build of Flame 3.0, the settings icon still displayed at left side of text. See attachment:settings_icon.png Rate:5/5 Flame 3.0 build: fail Build ID 20150319160212 Gaia Revision c39e15f631de80c69467fda0d4ea0bcda9e194ca Gaia Date 2015-03-18 19:30:04 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/cbd0efcd976c Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150319.193329 Firmware Date Thu Mar 19 19:33:42 EDT 2015 Bootloader L1TC000118D0

According to comment 31, reopen this bug.

Given that gaia revision (c39e15f631de80c69467fda0d4ea0bcda9e194ca), the commit for this bug wasn't included into that build yet [1]. Could you please, re-verify with today's mozilla-central, or flash latest master gaia on the current one to verify? Thanks! [1] https://github.com/mozilla-b2g/gaia/blob/c39e15f631de80c69467fda0d4ea0bcda9e194ca/apps/search/style/search.css#L23

This issue has been verified seccussfully on latest build of Flame 3.0, the settings icon is displayed at right side of text. See attachment:2015-03-22-20-09-46.png Rate:0/5 Flame 3.0 build: pass Build ID 20150322160204 Gaia Revision 9b6f3024e4d0e62dd057231f4b14abe1782932ab Gaia Date 2015-03-22 10:09:18 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/e730012260a4 Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150322.192413 Firmware Date Sun Mar 22 19:24:22 EDT 2015 Bootloader L1TC000118D0

NI myself for following v2.2 verification.

Alberto, could you uplift to 2.2? Thanks.

Comment on attachment 8577189 [details] [gaia] albertopq:1129701-icon-search > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Settings icon is on the wrong position on RTL [Testing completed]: Manual testing [Risk to taking this patch] (and alternatives if risky): Low risk. Only css and html [String changes made]: none

v2.2: https://github.com/mozilla-b2g/gaia/commit/5c46412cd51fe82a6fcf25cf78e14a17088357bd

Sue, could you verify 2.2 once pvt build includes this patch?

This patch had been uplifted to latest build of Flame 2.2, and this issue has been verified successfully on latest build of Flame 2.2, the settings icon is displayed at right side of text. See attachment:correct_settings_icon.png Rate:0/5 Device: Flame 2.2 (pass) Build ID 20150325162500 Gaia Revision 2d42a7c1d99472780e3aeb2e16d7cb0a4adbd222 Gaia Date 2015-03-25 20:46:52 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ebb742bfe1a4 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150325.200218 Firmware Date Wed Mar 25 20:02:30 EDT 2015 Bootloader L1TC000118D0