Thanks to Chris Peterson for spotting this. We should fix this on 36, because otherwise binary extensions might run into this problem and crash.

Also, let me know if you prefer "r=kgilbert" to "r=kip", ok?

Comment on attachment 8560250 [details] [diff] [review] Make sure the integer overload of ScrollBy calls the double one, not itself Review of attachment 8560250 [details] [diff] [review]: ----------------------------------------------------------------- This looks good, thanks for spotting it. Also, "r=kip" might be easiest for people that are trying to find me on irc by that handle.

Tracking for 36+ based on comment 0. Given that there is already a patch, let's try to get this into Beta 8, which goes to build on Monday.

Comment on attachment 8560250 [details] [diff] [review] Make sure the integer overload of ScrollBy calls the double one, not itself Approval Request Comment [Feature/regressing bug #]: Bug 1045754 [User impact if declined]: Some binary extensions may end up with stack-overflow crashes if they try to scroll windows from c++. [Describe test coverage new/current, TreeHerder]: None, sadly. [Risks and why]: Risk is very very low. [String/UUID change made/needed]: None.