Closed
Bug 1130452
Opened 10 years ago
Closed 10 years ago
remove Service Worker Cache "prefixMatch" option
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: bkelly, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
(deleted),
patch
|
bkelly
:
review+
baku
:
review+
|
Details | Diff | Splinter Review |
See:
https://github.com/slightlyoff/ServiceWorker/issues/617
Implementing prefixMatch is hard to do efficiently without indexing a potentially large TEXT column in the sqlite database. Its even harder when you throw in ignoreSearch.
The blink team agrees (and they haven't implemented it yet), so everyone seems in favor of simplifying and removing prefixMatch.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 1•10 years ago
|
||
Requesting review from baku on the WebIDL change.
Attachment #8573537 -
Flags: review?(bkelly)
Assignee | ||
Comment 2•10 years ago
|
||
(Note that I didn't change the schema to avoid stepping on Ben's toes.)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8573537 [details] [diff] [review]
Remove support for the prefixMatch option in the service worker cache code
Review of attachment 8573537 [details] [diff] [review]:
-----------------------------------------------------------------
Wow, I could have sworn I had a test that used prefixMatch. But I guess I don't. :-\
> (Note that I didn't change the schema to avoid stepping on Ben's toes.)
Yea, before we remove the URL indices I need to write code to hash the URL for exact matching. That's going to be a ton easier with prefix matching removed.
Thanks for doing this.
Attachment #8573537 -
Flags: review?(bkelly) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8573537 -
Flags: review?(amarchesini)
Comment 4•10 years ago
|
||
Comment on attachment 8573537 [details] [diff] [review]
Remove support for the prefixMatch option in the service worker cache code
Review of attachment 8573537 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/cache/DBSchema.cpp
@@ +676,5 @@
> urlToMatch = aRequest.url();
> query.AppendLiteral("request_url");
> }
>
> + query.AppendLiteral(" =?2 GROUP BY entries.id ORDER BY entries.id;");
extra space before '='
Attachment #8573537 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•