Closed
Bug 1130920
Opened 10 years ago
Closed 10 years ago
MSE addSourceBuffer stops due to PRELOAD_NONE is true on gonk pref.
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: ayang, Assigned: ayang)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
test item 3 on:
http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2015.html?timestamp=1423451570079
reason:
https://dxr.mozilla.org/mozilla-central/source/dom/html/HTMLMediaElement.cpp?from=HTMLMediaElement.cpp&case=true#867
The pref value of PRELOAD_NONE is true on gonk pref. We need to skip that when the source is from MSE.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8563868 -
Flags: review?(cpearce)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8563868 [details] [diff] [review]
skip_pref_preload_on_gonk
Review of attachment 8563868 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/html/HTMLMediaElement.cpp
@@ +1078,5 @@
> } else {
> // Find the appropriate preload action by looking at the attribute.
> const nsAttrValue* val = mAttrsAndChildren.GetAttr(nsGkAtoms::preload,
> kNameSpaceID_None);
> + // MSE doesn't work if repload is none, so it igonres the pref when src is
s/repload/preload/
s/igonres/ignores/
Attachment #8563868 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for review.
Attachment #8563868 -
Attachment is obsolete: true
Attachment #8564834 -
Flags: review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•