Closed
Bug 1130938
Opened 10 years ago
Closed 10 years ago
B2G RIL: Remove the duplicated RilWorkerBuffer in ril_worker.js
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox38 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: gweng, Assigned: gweng)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1123066 +++
Since in Bug 1123066 I did the wrong rebasing so the code still in ril_worker.js, while there is the new, independent ril_worker_buffer.js file. So in this bug I need to remove them from the ril_worker.js.
|
Assignee | |
Comment 1•10 years ago
|
||
Oh, sorry, cloning bug indicates to the wrong bug. The Bug should be Bug 1123201. This is because it's another cloned bug, too.
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 2•10 years ago
|
||
The try is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60587bb96c08
I'll submit the patch and set the review flag.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Patch: remove the duplicated code.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8561318 [details] [diff] [review]
Patch
Follow the first bug, set :aknow as the reviewer.
Attachment #8561318 -
Flags: review?(szchen)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → gweng
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8561318 [details] [diff] [review]
Patch
Review of attachment 8561318 [details] [diff] [review]:
-----------------------------------------------------------------
((Stealing the review ... ))
Thank you, Greg.
Attachment #8561318 -
Flags: review?(szchen) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
I've updated the patch to rebase it and add new review message.
Keeping the old patch to show the review flag is +.
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 8•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•