Closed Bug 1131577 Opened 10 years ago Closed 10 years ago

Waterfall view can scroll outside the visible bounds if the flamegraph view was initialized before a recording was started

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

STW (steps to wat):

1. Open new perf tool
2. Click on "JS Flame Chart" button
3. Start recording
4. Do some things in the webpage
5. Stop recording
6. Select "Waterfall"
7. Scroll to bottom

Bottom is under the bottom.
Attached patch v1 (deleted) — Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8562110 - Flags: review?(jsantell)
Comment on attachment 8562110 [details] [diff] [review]
v1

Review of attachment 8562110 [details] [diff] [review]:
-----------------------------------------------------------------

Good idea, as these panels can't be viewed anyway.
Attachment #8562110 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/integration/fx-team/rev/6692f4d0a461

Merged into gum: https://hg.mozilla.org/projects/gum/pushloghtml?changeset=665076c4cc75
Whiteboard: [fixed-in-fx-team]
This was merged to m-central, why wasn't it resolved? 
https://hg.mozilla.org/mozilla-central/rev/6692f4d0a461
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: