Closed
Bug 1131626
Opened 10 years ago
Closed 9 years ago
[e10s] Re-enable browser_bug295977_autoscroll_overflow.js and browser_keyevents_during_autoscrolling.js
Categories
(Toolkit :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
These tests cause a pile of assertions and the child process crashes.
When dispatchEvent is called:
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/moz2/working/dom/events/EventDispatcher.cpp, line 487
#01: mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, nsIDOMEvent*, nsPresContext*, nsEventStatus*) (EventDispatcher.cpp:704, in XUL)
Then, when synthesizeKey is called:
###!!! ABORT: can't send sync message of a lesser priority than what's being dispatched: file /builds/moz2/working/ipc/glue/MessageChannel.cpp, line 1825
As well as a lot of "unsafe CPOW usage" warnings.
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Updated•10 years ago
|
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Points: --- → 2
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8624470 [details] [diff] [review]
Fix the three autoscroll tests
Looks ok:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=630054a346f5
Attachment #8624470 -
Flags: review?(felipc)
Comment 3•9 years ago
|
||
Comment on attachment 8624470 [details] [diff] [review]
Fix the three autoscroll tests
Review of attachment 8624470 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/content/tests/browser/browser_keyevents_during_autoscrolling.js
@@ +89,2 @@
>
> +//yield new Promise(r => {});
remove commented line
Attachment #8624470 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/958e4293006dff60f8cb703335be335e9fc52ab6
Bug 1131626, fix autoscroll tests to work in e10s, r=felipe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•