Closed Bug 1131714 Opened 10 years ago Closed 10 years ago

TSan: data race js/src/gc/Marking.cpp:701 MarkIdInternal

Categories

(Core :: JavaScript: GC, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1135100

People

(Reporter: froydnj, Assigned: jonco)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [tsan])

Attachments

(1 file)

Attached file js-gc-race.txt (deleted) —
[cribbing from decoder's script, hopefully he won't mind] The attached logfile shows a thread/data race detected by TSan (ThreadSanitizer). Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1]. If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist. [1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
Fallout from CGC. This race is "safe": both threads will write the same output, even if there is a RAW ordering error. We should still fix the race though, maybe by using weak atomic ops. Forwarding to Jon to look at when he gets back from holiday.
Assignee: nobody → jcoppeard
Status: NEW → ASSIGNED
Flags: needinfo?(jcoppeard)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(jcoppeard)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: