Closed Bug 1131802 Opened 10 years ago Closed 10 years ago

remove use of parent in XrayAwareCalleeGlobal

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: sfink, Assigned: bzbarsky)

References

Details

Attachments

(3 files, 1 obsolete file)

Split out from bug 805052, item 14: XrayAwareCalleeGlobal uses the parent of the function to get to the Xray the function came from. Maybe we can use a reserved slot here too.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8570280 - Flags: review?(terrence) → review+
Blocks: 1131805
Depends on: 1140399
Attachment #8573966 - Flags: review?(peterv)
Attachment #8570281 - Attachment is obsolete: true
Attachment #8570281 - Flags: review?(peterv)
Attached patch Interdiff from previous part 2 (deleted) — Splinter Review
Comment on attachment 8573966 [details] [diff] [review] Part 2 updated with more asserts Review of attachment 8573966 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/xpconnect/wrappers/XrayWrapper.cpp @@ +126,5 @@ > + } > + > + // The functions we expect here have the Xray wrapper they're associated with > + // in their XRAY_DOM_FUNCTION_PARENT_WRAPPER_SLOT and, in a debug build, their > + // JSNAtive in their XRAY_DOM_FUNCTION_NATIVE_SLOT_FOR_ASSERT. Assert that JSNative
Attachment #8573966 - Flags: review?(peterv) → review+
Flags: needinfo?(bzbarsky)
OK, so... Looks like a JSNative pointer can have the low bit set in some cases (though apparently not on Mac on my machine?) so can't be stored in a PrivateValue. Peter, I'm going to switch to storing the function object itself and hoping that no one else would do such a silly thing.
Flags: needinfo?(bzbarsky)
Flags: needinfo?(bzbarsky)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: