Closed
Bug 1131802
Opened 10 years ago
Closed 10 years ago
remove use of parent in XrayAwareCalleeGlobal
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: sfink, Assigned: bzbarsky)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Split out from bug 805052, item 14: XrayAwareCalleeGlobal uses the parent of the function to get to the Xray the function came from. Maybe we can use a reserved slot here too.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8570280 -
Flags: review?(terrence)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8570281 -
Flags: review?(peterv)
Updated•10 years ago
|
Attachment #8570280 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8573966 -
Flags: review?(peterv)
Assignee | ||
Updated•10 years ago
|
Attachment #8570281 -
Attachment is obsolete: true
Attachment #8570281 -
Flags: review?(peterv)
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8573966 [details] [diff] [review]
Part 2 updated with more asserts
Review of attachment 8573966 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +126,5 @@
> + }
> +
> + // The functions we expect here have the Xray wrapper they're associated with
> + // in their XRAY_DOM_FUNCTION_PARENT_WRAPPER_SLOT and, in a debug build, their
> + // JSNAtive in their XRAY_DOM_FUNCTION_NATIVE_SLOT_FOR_ASSERT. Assert that
JSNative
Attachment #8573966 -
Flags: review?(peterv) → review+
Comment 7•10 years ago
|
||
Backed out for assertion failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc86a4e16519
Updated•10 years ago
|
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 8•10 years ago
|
||
OK, so... Looks like a JSNative pointer can have the low bit set in some cases (though apparently not on Mac on my machine?) so can't be stored in a PrivateValue.
Peter, I'm going to switch to storing the function object itself and hoping that no one else would do such a silly thing.
Flags: needinfo?(bzbarsky)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 9•10 years ago
|
||
Relanded with that change:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94a0946d5a0a
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdb146bc4052
Flags: needinfo?(bzbarsky)
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/94a0946d5a0a
https://hg.mozilla.org/mozilla-central/rev/fdb146bc4052
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•