Closed
Bug 1131871
Opened 10 years ago
Closed 10 years ago
auto_com should only uninitialize when successful
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: away, Unassigned)
Details
Attachments
(1 file)
|
(deleted),
patch
|
padenot
:
review+
kinetik
:
feedback+
|
Details | Diff | Splinter Review |
Noticed this while reading the code. In rare cases CoInit can return other error codes; those shouldn't cause an uninit.
As a separate matter (one that I don't feel comfortable patching myself), shouldn't the caller check the hr and abort if it failed? It was that way prior to bug 848954.
Attachment #8562451 -
Flags: review?(padenot)
|
||
Updated•10 years ago
|
Attachment #8562451 -
Flags: feedback+
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8562451 [details] [diff] [review]
patch
Review of attachment 8562451 [details] [diff] [review]:
-----------------------------------------------------------------
ah yeah indeed.
Attachment #8562451 -
Flags: review?(padenot) → review+
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•