Closed Bug 1131878 Opened 10 years ago Closed 10 years ago

Look in to re-enabling e10s in the harness

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
e10s + ---

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

PR fixing stuff
(deleted), text/x-github-pull-request
whimboo
: review+
Details
Bug 1047603 is in some stage of landing and should fix the window.open() issues that motivated shutting off e10s.
Depends on: 1047603
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [blocked]
With bug 1047603 landed now, can e10s be re-enabled in the harness?
Flags: needinfo?(cmanchester)
The other concern was not being able to handle remoteness changes (navigation to/from non-remote about: pages). I'm working on that this week, :whimboo should we block on that as well?
Flags: needinfo?(cmanchester) → needinfo?(hskupin)
Yes, we need about:error pages a lot in the security tests, which are now our P1.
Flags: needinfo?(hskupin)
Summary: Look in to re-enabling e10s in the harness once window.open is fixed → Look in to re-enabling e10s in the harness
Whiteboard: [blocked]
Attached file PR fixing stuff (deleted) —
Everything passes with e10s now. We can leave it off if it's problematic for in-progress test conversion, but might as well get this in.
Attachment #8576321 - Flags: review?(hskupin)
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
Comment on attachment 8576321 [details] PR fixing stuff Lovely. What about generally enabling e10s? Are we still blocked on something else? I can remember problems with window.open(). Are those still present?
Attachment #8576321 - Flags: review?(hskupin) → review+
(In reply to Henrik Skupin (:whimboo) from comment #5) > Comment on attachment 8576321 [details] > PR fixing stuff > > Lovely. What about generally enabling e10s? Are we still blocked on > something else? I can remember problems with window.open(). Are those still > present? Nothing I know of, all our tests pass with e10s on locally. Like I said we can leave it off for a little while if we're worried about disturbing in-progress test work, but let's see if that's an issue.
I merged the PR here: https://github.com/mozilla/firefox-ui-tests/commit/0bf41b07cc43ff8e9657dddc966e236aff308db4 I'll leave the bug open until we actually turn it on.
What about the --e10s option? This would work at the moment already?
(In reply to Henrik Skupin (:whimboo) from comment #8) > What about the --e10s option? This would work at the moment already? Yep!
Bug 1162408 gets these running in parallel to non-e10s in our Travis tests with a small number still disabled.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: