Closed
Bug 1132161
Opened 10 years ago
Closed 2 years ago
move system/stl header wrapping from config/Makefile.in into moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1407432
People
(Reporter: froydnj, Unassigned)
Details
Our makefile rules for wrapping system/stl headers is rather large:
http://mxr.mozilla.org/mozilla-central/source/config/Makefile.in#63
We should just have something like:
WRAPPED_SYSTEM_INCLUDES += ['system-headers']
WRAPPED_STL_INCLUDES += ['stl-headers']
and let moz.build generate the appropriate rules, or do the generating itself, or whatever.
Bonus:
- we don't have to use make-system-wrappers.pl from NSPR anymore
- we don't have to generate the headers in a temporary directory; we can generate them directly into dist/include/
Comment 1•10 years ago
|
||
I'd say we don't need this in moz.build at all, we could just call a python script to generate it from configure. The only thing that might be weird is generating the rules to rebuild if the deps change, but I don't think it's that complicated.
Reporter | ||
Comment 2•10 years ago
|
||
I didn't know if we had to care about PGO builds still blowing away dist/. If we don't, then just generating it at configure time would be sufficient and better.
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•