Windows 8 64-bit mozilla-inbound debug test mochitest-3 https://treeherder.mozilla.org/logviewer.html#?job_id=6552446&repo=mozilla-inbound 17:20:03 WARNING - PROCESS-CRASH | dom/media/test/test_eme_playback.html | application crashed [@ mozilla::dom::MediaKeys::Release()] 17:20:03 INFO - Crash dump filename: c:\users\cltbld~1.t-w\appdata\local\temp\tmpqd0yb2.mozrunner\minidumps\80c99635-a1fd-4d0a-94f2-8ae7920f7e23.dmp 17:20:03 INFO - Operating system: Windows NT 17:20:03 INFO - 6.2.9200 17:20:03 INFO - CPU: amd64 17:20:03 INFO - family 6 model 30 stepping 5 17:20:03 INFO - 8 CPUs 17:20:03 INFO - Crash reason: EXCEPTION_ACCESS_VIOLATION_READ 17:20:03 INFO - Crash address: 0x20 17:20:03 INFO - Thread 0 (crashed) 17:20:03 INFO - 0 xul.dll!mozilla::dom::MediaKeys::Release() [MediaKeys.cpp:a2e7a9e606aa : 42 + 0xf] 17:20:03 INFO - rbx = 0x000000fd901e0c18 r12 = 0x000000fd801ff500 17:20:03 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000 17:20:03 INFO - r15 = 0x0000000000000000 rip = 0x000007fdb6582a0f 17:20:03 INFO - rsp = 0x000000fd801ff130 rbp = 0x000000fd801ff260 17:20:03 INFO - Found by: given as instruction pointer in context 17:20:03 INFO - 1 xul.dll!mozilla::dom::CloseSessions [MediaKeys.cpp:a2e7a9e606aa : 85 + 0x7] 17:20:03 INFO - rbx = 0x000000fd901e0c18 r12 = 0x000000fd801ff500 17:20:03 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000 17:20:03 INFO - r15 = 0x0000000000000000 rip = 0x000007fdb657b741 17:20:03 INFO - rsp = 0x000000fd801ff170 rbp = 0x000000fd801ff260 17:20:03 INFO - Found by: call frame info 17:20:03 INFO - 2 xul.dll!PLDHashTable::Enumerate(PLDHashOperator (*)(PLDHashTable *,PLDHashEntryHdr *,unsigned int,void *),void *) [pldhash.cpp:a2e7a9e606aa : 751 + 0xe] 17:20:03 INFO - rbx = 0x000000fd901e0c18 r12 = 0x000000fd801ff500 17:20:03 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000 17:20:03 INFO - r15 = 0x0000000000000000 rip = 0x000007fdb4809874 17:20:03 INFO - rsp = 0x000000fd801ff1b0 rbp = 0x000000fd801ff260 17:20:03 INFO - Found by: call frame info 17:20:03 INFO - 3 xul.dll!nsBaseHashtable<nsStringHashKey,nsRefPtr<mozilla::dom::MediaKeySession>,mozilla::dom::MediaKeySession *>::Enumerate(PLDHashOperator (*)(nsAString_internal const &,nsRefPtr<mozilla::dom::MediaKeySession> &,void *),void *) [nsBaseHashtable.h:a2e7a9e606aa : 208 + 0x1d] 17:20:03 INFO - rbx = 0x000000fd901e0c18 r12 = 0x000000fd801ff500 17:20:03 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000 17:20:03 INFO - r15 = 0x0000000000000000 rip = 0x000007fdb657d1b7

correct place to call MediaKeys::Release() during shutdown.

Comment on attachment 8563265 [details] [diff] [review] 1132366_wrong_place_to_release-v1.patch Review of attachment 8563265 [details] [diff] [review]: ----------------------------------------------------------------- Ouch.

Try: https://tbpl.mozilla.org/?tree=Try&rev=7db3ea602adc

Patch for beta branch as part of EME platform uplift.

Comment on attachment 8572367 [details] [diff] [review] Beta patch Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment on attachment 8572367 [details] [diff] [review] Beta patch Approved for Beta as part of EME platform uplift.