Closed
Bug 1132790
Opened 10 years ago
Closed 10 years ago
[Stingray] Create Smart-Dialog component
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: suchiu, Assigned: suchiu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-github-pull-request
|
Details |
1. Build smart-dialog web component for smart-tv that will perform circle animation during opening and closing.
|
Assignee | |
Updated•10 years ago
|
Blocks: smart-components
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8563875 -
Flags: review?(im)
|
|
Assignee | |
Comment 2•10 years ago
|
||
1. Perform circle animation on smart-dialog during opening and closing.
2. Use both transitionend and setTimeout event to bring the smart-button back to the final state.
3. Content inside smart-dialog is only visible in opened state.
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8563875 [details]
[gaia] sean2449:Bug_1132790 > mozilla-b2g:master
Please check my comments at PR. Since we create a container element, we shouldn't change CSS `display` to `block` once opened. We should use another way to hide the child components. Please update the patch and set the review flag again. Thanks.
Attachment #8563875 -
Flags: review?(im)
|
|
||
Comment 4•10 years ago
|
||
Please land the patch to https://github.com/smart-components repo and file bugs to change the dialog in tv_apps to smart dialog.
| Comment hidden (obsolete) |
|
||
Comment 6•10 years ago
|
||
Smart dialog repo: https://github.com/smart-components/smart-dialog
|
|
Assignee | |
Comment 7•10 years ago
|
||
Attachment #8563875 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•10 years ago
|
||
Merge to smart-dialog:master https://github.com/smart-components/smart-dialog/commit/e35e3a934ec575d829643729b68202c32be1e6d3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•