Closed
Bug 1132801
Opened 10 years ago
Closed 10 years ago
L10nError: "ime-settings" not found in en-US in app://system.gaiamobile.org/index.html
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(b2g-v2.0 wontfix, b2g-v2.0M wontfix, b2g-v2.1 wontfix, b2g-v2.1S wontfix, b2g-v2.2 wontfix, b2g-master fixed)
People
(Reporter: timdream, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
[Blocking Requested - why for this release]: The l10n id "ime-settings" was committed in bug 1003649 but the l10n string was never added into properties files. https://github.com/mozilla-b2g/gaia/commit/10cae623e17f98509750342e24e61cbe06abdb72 Unless it's added but accidentally removed, this bug affects all the way to 2.0. We sadly have to do late-l10n work or wontfix on these branches. :pike, what should we do here?
Flags: needinfo?(rlu)
Flags: needinfo?(l10n)
|
Reporter | |
Comment 1•10 years ago
|
||
With |grep -r ime-settings apps/system| on v2.0/v2.1/v2.2 branches I can verify this bug affects on all versions.
status-b2g-v2.0:
--- → affected
status-b2g-v2.0M:
--- → affected
status-b2g-v2.1:
--- → affected
status-b2g-v2.1S:
--- → affected
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → affected
|
||
Comment 2•10 years ago
|
||
|
Assignee | |
Comment 3•10 years ago
|
||
I think this l10n id "ime-settings" is not used in our current implementation of IME menu. I should have removed that reference in the code, but seems I missed this.
Flags: needinfo?(rlu)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8563927 [details] [gaia] RudyLu:ime/Bug1132801 > mozilla-b2g:master Since this string is not used for now, guess we could remove the late-l10n here, and just remove the reference of this id from code. Tim, could you please help review this? Thank you.
Flags: needinfo?(l10n)
Attachment #8563927 -
Flags: review?(timdream)
|
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8563927 [details] [gaia] RudyLu:ime/Bug1132801 > mozilla-b2g:master Please document the patch, not the bug, in the commit message.
Attachment #8563927 -
Flags: review?(timdream) → review+
|
|
Reporter | |
Comment 6•10 years ago
|
||
(In reply to Rudy Lu [:rudyl] from comment #3) > I think this l10n id "ime-settings" is not used in our current > implementation of IME menu. > I should have removed that reference in the code, but seems I missed this. We don't need to fix this in all branches then. Update the flags here.
blocking-b2g: 2.0? → ---
|
|
Assignee | |
Comment 7•10 years ago
|
||
Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/cfa2f00fbf6e3861ed6878b3bc74bd5284989c29
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•