Closed
Bug 1132960
Opened 10 years ago
Closed 10 years ago
Build bustage with --disable-accessibility (fatal error C1083: Cannot open include file: 'nsIAccessibleText.h')
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: RyanVM, Assigned: smaug)
References
Details
Attachments
(1 file)
(deleted),
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
I have --disable-accessibility set.
5:17.28 c:\Users\Ryan\repos\mozilla-central\objdir-fx-64\ipc\ipdl\_ipdlheaders\mozilla/a11y/PDocAccessibleChild.h(17) : fatal error C1083: Cannot open include file: 'nsIAccessibleText.h': No such file or directory
Reporter | ||
Comment 1•10 years ago
|
||
Whoops, this is bustage from bug 1127402.
Reporter | ||
Comment 2•10 years ago
|
||
Or maybe bug 1132485, which landed directly before that.
Flags: needinfo?(bugs)
Assignee | ||
Comment 3•10 years ago
|
||
Hmm, sounds like we should not process any accessibility related ipc code if
--disable-accessibility is used. bug 1132485 just happened to reveal that issue.
Flags: needinfo?(bugs)
Reporter | ||
Updated•10 years ago
|
Assignee | ||
Comment 4•10 years ago
|
||
Except that in moz.build there is the comment
"with --disable-accessibility we need to compile PDocAccessible.ipdl, but not the C++."
I don't know why we want to process the .ipdl file. Trevor, do you know?
Assignee | ||
Comment 5•10 years ago
|
||
Hmm, I guess preprocessing ipdl files can be tricky.
Comment 6•10 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #0)
> I have --disable-accessibility set.
>
> 5:17.28
> c:\Users\Ryan\repos\mozilla-central\objdir-fx-
> 64\ipc\ipdl\_ipdlheaders\mozilla/a11y/PDocAccessibleChild.h(17) : fatal
> error C1083: Cannot open include file: 'nsIAccessibleText.h': No such file
> or directory
is there a trace where that's included from / what command is this?
(In reply to Olli Pettay [:smaug] from comment #4)
> Except that in moz.build there is the comment
> "with --disable-accessibility we need to compile PDocAccessible.ipdl, but
> not the C++."
>
> I don't know why we want to process the .ipdl file. Trevor, do you know?
because its included in PContent
Flags: needinfo?(tbsaunde+mozbugs)
Reporter | ||
Comment 7•10 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #6)
> is there a trace where that's included from / what command is this?
The only thing I see before it is that it's dying when compiling UnifiedProtocols5.cpp and UnifiedProtocols6.cpp. Here's a Try push w/ a11y disabled in case that gives you something more to go off.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60ee56036bf0
Assignee | ||
Comment 8•10 years ago
|
||
One option to fix this is to not rely on the typedef in the .idl. A bit ugly, but would work.
yet any fix?
still stopped my firefox build on fedora 21.
make[5]: Leaving directory '/home/reandr/firebuild/mybuild/config/external/nspr'
c++ -o UnifiedProtocols6.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /home/reandr/firebuild/mysrc/config/gcc_hidden.h -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/home/reandr/firebuild/mysrc/ipc/ipdl -I. -I/home/reandr/firebuild/mybuild/ipc/ipdl/_ipdlheaders -I/home/reandr/firebuild/mysrc/ipc/chromium/src -I/home/reandr/firebuild/mysrc/ipc/glue -I../../dist/include -I/home/reandr/firebuild/mybuild/dist/include/nspr -I/home/reandr/firebuild/mybuild/dist/include/nss -I/usr/include/pixman-1 -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/UnifiedProtocols6.o.pp -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -O3 -msse2 -mfpmath=sse -fomit-frame-pointer -I/home/reandr/firebuild/mysrc/widget/gtk/compat -pthread -I/usr/include/gtk-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include /home/reandr/firebuild/mybuild/ipc/ipdl/UnifiedProtocols6.cpp
UnifiedProtocols7.o
In file included from /home/reandr/firebuild/mybuild/ipc/ipdl/PDocAccessibleChild.cpp:7:0,
from /home/reandr/firebuild/mybuild/ipc/ipdl/UnifiedProtocols6.cpp:101:
/home/reandr/firebuild/mybuild/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:17:31: fatal error: nsIAccessibleText.h: no such file
#include "nsIAccessibleText.h"
^
compilation terminated.
In file included from /home/reandr/firebuild/mybuild/ipc/ipdl/PContentChild.cpp:26:0,
from /home/reandr/firebuild/mybuild/ipc/ipdl/UnifiedProtocols5.cpp:38:
/home/reandr/firebuild/mybuild/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:17:31: fatal error: nsIAccessibleText.h: no such file
#include "nsIAccessibleText.h"
^
compilation terminated.
/home/reandr/firebuild/mysrc/config/rules.mk:930: recipe for target 'UnifiedProtocols6.o' failed
Assignee | ||
Comment 10•10 years ago
|
||
for now the solution is to not use --disable-accessibility,
but I'll upload a patch to use int32_t in ipdl, and not AccessibleTextBoundary.
Assignee | ||
Comment 11•10 years ago
|
||
Assignee: nobody → bugs
Attachment #8565124 -
Flags: review?(tbsaunde+mozbugs)
Updated•10 years ago
|
Component: Build Config → Disability Access APIs
OS: Windows 8.1 → All
Hardware: x86 → All
Version: unspecified → Trunk
Updated•10 years ago
|
Attachment #8565124 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Assignee | ||
Comment 13•10 years ago
|
||
Reporter | ||
Comment 14•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•